Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/huaweicloudces] move huaweicloudces receiver to alpha #36782

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

narcis96
Copy link
Contributor

@narcis96 narcis96 commented Dec 11, 2024

Description:
Move the huaweicloudces to alpha, as it is feature complete.

Add the receiver to the cmd/otelcontribcol binary.

Link to tracking issue
#34953

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Dec 26, 2024
Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind adding a changelog entry and fixing the conflicting files?

@mwear mwear removed the Stale label Dec 26, 2024
@narcis96
Copy link
Contributor Author

will do that

@narcis96 narcis96 closed this Dec 29, 2024
@narcis96 narcis96 reopened this Dec 29, 2024
@narcis96
Copy link
Contributor Author

narcis96 commented Jan 5, 2025

done. PTAL @mwear

@mwear
Copy link
Member

mwear commented Jan 6, 2025

Can you take a look at the failing check? It appears to be go.mod related.

@narcis96
Copy link
Contributor Author

narcis96 commented Jan 7, 2025

to me the failing check seem unrelated to this PR:

Capture

Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @narcis96!

@mwear mwear added the ready to merge Code review completed; ready to merge by maintainers label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/otelcontribcol otelcontribcol command ready to merge Code review completed; ready to merge by maintainers receiver/huaweicloudces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants