Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][internal/k8stest] Make k8stest package publicly available #36661

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[chore][internal/k8stest] Make k8stest package publicly available #36661

wants to merge 2 commits into from

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Dec 4, 2024

Description

Link to tracking issue

Part of #36615

@odubajDT odubajDT changed the title [chore][pkg/k8stest][internal/k8stest] Make k8stest package publicly available [chore][internal/k8stest] Make k8stest package publicly available Dec 4, 2024
@odubajDT odubajDT marked this pull request as ready for review December 4, 2024 08:58
@odubajDT odubajDT requested a review from a team as a code owner December 4, 2024 08:58
jade-guiton-dd
jade-guiton-dd approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@jade-guiton-dd jade-guiton-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on the Datadog side.

TylerHelmuth
TylerHelmuth previously requested changes Dec 5, 2024
View reviewed changes
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to continue discussing this proposal in the issue. Making things public puts a burden on maintaining.

@odubajDT
Copy link
Contributor Author

odubajDT commented Dec 6, 2024

I'd like to continue discussing this proposal in the issue. Making things public puts a burden on maintaining.

Sure, let's discuss. I opened this PR just to visualize what I am proposing.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 1, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 1, 2025
@odubajDT
Copy link
Contributor Author

odubajDT commented Jan 2, 2025

not stale

@github-actions github-actions bot removed the Stale label Jan 3, 2025
@TylerHelmuth TylerHelmuth dismissed their stale review January 9, 2025 20:04

unblocking based on discussion in issue

@github-actions github-actions bot requested a review from IbraheemA January 20, 2025 06:17
@odubajDT
go mod tidy
15b2a9c 
Signed-off-by: odubajDT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-bradley evan-bradley evan-bradley left review comments

@jade-guiton-dd jade-guiton-dd jade-guiton-dd approved these changes

@povilasv povilasv povilasv approved these changes

@ChrsMark ChrsMark ChrsMark approved these changes

@mx-psi mx-psi mx-psi approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth left review comments

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@ankitpatel96 ankitpatel96 Awaiting requested review from ankitpatel96

@atoulme atoulme Awaiting requested review from atoulme

@carsonip carsonip Awaiting requested review from carsonip

@crobert-1 crobert-1 Awaiting requested review from crobert-1 crobert-1 is a code owner

@dao-jun dao-jun Awaiting requested review from dao-jun

@dineshg13 dineshg13 Awaiting requested review from dineshg13

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 is a code owner

@frzifus frzifus Awaiting requested review from frzifus

@hvaghani221 hvaghani221 Awaiting requested review from hvaghani221

@JaredTan95 JaredTan95 Awaiting requested review from JaredTan95

@jmacd jmacd Awaiting requested review from jmacd

@jpkrohling jpkrohling Awaiting requested review from jpkrohling

@lahsivjar lahsivjar Awaiting requested review from lahsivjar

@liustanley liustanley Awaiting requested review from liustanley

@mackjmr mackjmr Awaiting requested review from mackjmr

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@songy23 songy23 Awaiting requested review from songy23 songy23 is a code owner

@VihasMakwana VihasMakwana Awaiting requested review from VihasMakwana

@yotamloe yotamloe Awaiting requested review from yotamloe

@yurishkuro yurishkuro Awaiting requested review from yurishkuro

@IbraheemA IbraheemA Awaiting requested review from IbraheemA

Assignees

@dmitryax dmitryax

Labels
cmd/otelcontribcol otelcontribcol command connector/datadog exporter/awskinesis exporter/datadog Datadog components exporter/elasticsearch exporter/kafka exporter/logzio exporter/pulsar exporter/sapm exporter/zipkin extension/encoding pkg/translator/jaeger pkg/translator/zipkin processor/k8sattributes k8s Attributes processor processor/probabilisticsampler Probabilistic Sampler processor receiver/jaeger receiver/k8scluster receiver/k8sobjects receiver/kafka receiver/kubeletstats receiver/pulsar receiver/sapm receiver/zipkin Zipkin receiver testbed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@odubajDT @mx-psi @evan-bradley @ChrsMark @TylerHelmuth @povilasv @jade-guiton-dd @dmitryax