Minor updates #18
Minor updates #18
Conversation
ampo0809
commented
Nov 10, 2024
ampo0809
commented
- Modified access levels
- Updated default parameters
| 0.1544, 1.0824, 1.9813, 0.0953, 0.2975, 2.2042, 0.2407, 2.9466, 0.5034, | ||
| 0.6567, | ||
| ] | ||
| var defaultW = [0.40255, 1.18385, 3.173, 15.69105, 7.1949, 0.5345, 1.4604, 0.0046, 1.54575, 0.1192, 1.01925, 1.9395, 0.11, 0.29605, 2.2698, 0.2315, 2.9898, 0.51655, 0.6621] |
There was a problem hiding this comment.
@L-M-Sherlock Please check the defaultW is right or not. Other changes look good to me.
There was a problem hiding this comment.
There was a problem hiding this comment.
I did copy them from that link. Sorry, forgot to pay an eye to to tests.
There was a problem hiding this comment.
This project currently is tracking ts-fsrs changes, the tests too, but this change is come from fsrs-rs, seems like a newer version default parameters, that way, we should update the tests as well. But there is other things need consider, I am not sure the algo is updated as well in fsrs-rs or not.
@L-M-Sherlock Do you have time to confirm this? 😛
There was a problem hiding this comment.
I recommend reverting the change of default weights.
|
It seems some tests are not passed. @ampo0809 |
|
Oops. The unit tests are still based on the old parameters. |
|
In ts-fsrs, the following is used for uploading coverage reports to Codecov: - name: Upload coverage reports to Codecov
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
fail_ci_if_error: true |
|
Is the token store in project settings expired or changed? @L-M-Sherlock @ishiko732 |
I do not know what the token currently set for the repo is. Please @L-M-Sherlock check the token: https://app.codecov.io/gh/open-spaced-repetition/swift-fsrs/config/general |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
