Set Kyber OIDs #368
Merged
Set Kyber OIDs #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feventura
pushed a commit
to EntrustCorporation/oqs-provider
that referenced
this pull request
Mar 13, 2024
* Fix OIDs for Kyber (r3) * fix comments in generate.sh [skip ci] * run clang-format Signed-off-by: Felipe Ventura <[email protected]>
feventura
pushed a commit
to EntrustCorporation/oqs-provider
that referenced
this pull request
Mar 16, 2024
* Fix OIDs for Kyber (r3) * fix comments in generate.sh [skip ci] * run clang-format Signed-off-by: Felipe Ventura <[email protected]>
feventura
pushed a commit
to EntrustCorporation/oqs-provider
that referenced
this pull request
Mar 17, 2024
* Fix OIDs for Kyber (r3) * fix comments in generate.sh [skip ci] * run clang-format Signed-off-by: Felipe Ventura <[email protected]>
feventura
pushed a commit
to EntrustCorporation/oqs-provider
that referenced
this pull request
Mar 17, 2024
* Fix OIDs for Kyber (r3) * fix comments in generate.sh [skip ci] * run clang-format Signed-off-by: Felipe Ventura <[email protected]>
feventura
pushed a commit
to EntrustCorporation/oqs-provider
that referenced
this pull request
Mar 17, 2024
* Fix OIDs for Kyber (r3) * fix comments in generate.sh [skip ci] * run clang-format Signed-off-by: Felipe Ventura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets Kyber (round 3) OIDs as suggested in #351.
Done by adding the OIDs to generate.yml and running generate.sh
OIDs:
Kyber512: 1.3.6.1.4.1.2.267.8.2.2
Kyber768: 1.3.6.1.4.1.2.267.8.3.3
Kyber1024: 1.3.6.1.4.1.2.267.8.4.4
Note that the generate-script also updated the "random" KEM OIDs, which is intended, see #348 (comment)
Two other minor changes: