-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set ML-KEM alg_version to "FIPS203" #1997
Conversation
Signed-off-by: Spencer Wilson <[email protected]>
Signed-off-by: Spencer Wilson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty massive changes for 3 lines of code... Ideas why this is so?
I did wonder about this also. I generated the patch using I'm fine to update the patch with |
Thanks @SWilson4 for updating this! You're right, the original patch was made with |
Signed-off-by: Spencer Wilson <[email protected]>
Looking for one more review @open-quantum-safe/liboqs-committers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
To bring ML-KEM in line with the upcoming ML-DSA update.
Fixes #1996