Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak when using OpenSSL and threads #1942

Closed
wants to merge 12 commits into from
Closed

Fix memory leak when using OpenSSL and threads #1942

wants to merge 12 commits into from

Commits on Oct 22, 2024

  1. init OpenSSL when OQS_USE_OPENSSL is enabled in liboqs. 

    Signed-off-by: Norman Ashley <[email protected]>
    @ashman-p
    ashman-p committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    e142979 View commit details
    Browse the repository at this point in the history

  2. wrap OPENSSL_init_crypto with OSSL_FUNC. 

    Signed-off-by: Norman Ashley <[email protected]>
    @ashman-p
    ashman-p committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    c8abddd View commit details
    Browse the repository at this point in the history

  3. Add OPENSSL_init_crypto to the list of OpenSSL functions called liboqs. 

    Signed-off-by: Norman Ashley <[email protected]>
    @ashman-p
    ashman-p committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    c7b44d9 View commit details
    Browse the repository at this point in the history

  4. Revert files 

    Signed-off-by: Norman Ashley <[email protected]>
    @ashman-p
    ashman-p committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    d3b56fc View commit details
    Browse the repository at this point in the history

  5. Don't include dlfcn.h for Windows (open-quantum-safe#1936) 

    Signed-off-by: Steen Rasmussen <[email protected]>
Co-authored-by: Steen Rasmussen <[email protected]>
Signed-off-by: Norman Ashley <[email protected]>
    @steenrasmussen @ashman-p
    2 people authored and ashman-p committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    05f64d2 View commit details
    Browse the repository at this point in the history

  6. Update CBOM format to upstream v1.6 (open-quantum-safe#1834) 

    Signed-off-by: Basil Hess <[email protected]>
Signed-off-by: Norman Ashley <[email protected]>
    @bhess @ashman-p
    bhess authored and ashman-p committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    17dd36d View commit details
    Browse the repository at this point in the history

  7. Cleanup threading resources when OpenSSL is used. 

    Signed-off-by: Norman Ashley <[email protected]>
    @ashman-p
    ashman-p committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    b48c694 View commit details
    Browse the repository at this point in the history

  8. Add OPENSSL_thread_stop to the ossl function list. Cleanup error chec… 

    …king.

Signed-off-by: Norman Ashley <[email protected]>
    @ashman-p
    ashman-p committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    61f9691 View commit details
    Browse the repository at this point in the history

  9. Update ossl_helpers.c 

    Remove OPENSSL build-time macro from helper functions.

Signed-off-by: Norman Ashley <[email protected]>
    @ashman-p
    ashman-p committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    b2bfe6a View commit details
    Browse the repository at this point in the history

  10. Apply suggestions from code review 

    Use of OQS_DLOPEN_OPENSSL needs a new API change to expose an OQS function that calls  OPENSSL_thread_stop

Signed-off-by: Norman Ashley <[email protected]>
    @ashman-p
    ashman-p committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    c8e8651 View commit details
    Browse the repository at this point in the history

  11. Update tests/test_sig.c 

    Use of OQS_DLOPEN_OPENSSL needs a new API change to expose an OQS function that calls  OPENSSL_thread_stop

Signed-off-by: Norman Ashley <[email protected]>
    @ashman-p
    ashman-p committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    457480d View commit details
    Browse the repository at this point in the history

  12. Update tests/test_kem.c 

    Use of OQS_DLOPEN_OPENSSL needs a new API change to expose an OQS function that calls  OPENSSL_thread_stop

Signed-off-by: Norman Ashley <[email protected]>
    @ashman-p
    ashman-p committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    195f61e View commit details
    Browse the repository at this point in the history