-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes after adding ML-* #1702
Conversation
- Fixes fetch_values.sh script to (re-)generate ML-* vectors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ascertain aliases and originals operate identically. Current problem: Header-defines (can -- and do) mismatch (see single comment).
A (non-merge-blocking) comment, though: I understand you have a propensity to retain the "*-ipd" algorithms as "STD" algorithms, but I personally consider this logically incorrect and my suggestion is to not include them in this algorithm selection. Rationale: As and when a v2 ipd arrives or when ipd gets approved as final, they will need to be manually removed from this list again -- in other words, no matter what, they will need to be removed eventually; in turn, the algorithm names without "-ipd" moniker are standardized and will remain the name of valid "STD" algorithms, whatever their underlying implementation. -> If you don't want to subscribe to this logic, may I then suggest to at least add a comment to this code along the lines "TBD - manually revise as standard process moves on"? Then we could create a script scouring for "TBD" monikers and consciously decide whether or not this (and other instances containing such aide memoire) is still OK when doing a release. |
I agree that adding the non-ipd alias in the STD list would be sufficient to track the latest versions (which I think is the goal of "STD" as the algorothms there are not in final-standard phase yet but rather "selected to be standardized and in their latest draft phase"). With #1703 / #1704 addressed, the latest version (-ipd or -ipdv2...) macros would then automatically be enabled as well, and explicitly adding -ipd to the STD list will not be needed anymore. |
Two small fixes after #1626: