Skip to content

Commit

Permalink
Update constant-time passes after linenumer and function name changes…
Browse files Browse the repository at this point in the history
… [extended tests]

Signed-off-by: Basil Hess <[email protected]>
  • Loading branch information
bhess committed Nov 13, 2024
1 parent 5f7d3fd commit 420e87e
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 22 deletions.
18 changes: 9 additions & 9 deletions tests/constant_time/sig/passes/ml_dsa
Original file line number Diff line number Diff line change
Expand Up @@ -18,53 +18,53 @@
Memcheck:Cond
fun:rej_gamma1m1
fun:pqcrystals_ml_dsa*_ref_poly_uniform_gamma1m1
fun:crypto_sign_signature_ctx
fun:pqcrystals_ml_dsa*_ref_signature_internal
}
{
Rejection sampling for challenge
Memcheck:Cond
fun:pqcrystals_ml_dsa*_ref_poly_challenge
fun:crypto_sign_signature_ctx
fun:pqcrystals_ml_dsa*_ref_signature_internal
}
{
Rejection sampling for challenge
Memcheck:Value8
fun:pqcrystals_ml_dsa*_ref_poly_challenge
fun:crypto_sign_signature_ctx
fun:pqcrystals_ml_dsa*_ref_signature_internal
}
{
Rejection sampling for signature distribution
Memcheck:Cond
...
src:sign.c:166 # Call to polyvecl_chknorm
src:sign.c:161 # Call to polyvecl_chknorm
# fun:pqcrystals_ml_dsa*_ref_signature
}
{
Rejection sampling for signature distribution
Memcheck:Cond
...
src:sign.c:175 # Call to polyveck_chknorm
src:sign.c:170 # Call to polyveck_chknorm
# fun:pqcrystals_ml_dsa*_ref_signature
}
{
Rejection sampling for signature distribution
Memcheck:Cond
...
src:sign.c:182 # Call to polyveck_chknorm
src:sign.c:177 # Call to polyveck_chknorm
# fun:pqcrystals_ml_dsa*_ref_signature
}
{
Hint does not need to be computed in constant time
Memcheck:Cond
...
src:sign.c:186 # Call to polyveck_make_hint
src:sign.c:181 # Call to polyveck_make_hint
# fun:pqcrystals_ml_dsa*_ref_signature
}
{
Rejection sampling for hint
Memcheck:Cond
...
src:sign.c:187 # Checking number of 1 bits in hint
src:sign.c:182 # Checking number of 1 bits in hint
# fun:pqcrystals_ml_dsa*_ref_signature
}
{
Expand All @@ -76,5 +76,5 @@
{
Verification is not done in constant time
Memcheck:Cond
fun:pqcrystals_ml_dsa*_ref_verify
fun:pqcrystals_ml_dsa*_ref_verify_internal
}
26 changes: 13 additions & 13 deletions tests/constant_time/sig/passes/ml_dsa-avx2
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,14 @@
Memcheck:Cond
...
fun:pqcrystals_ml_dsa*_avx2_poly_uniform_gamma1m1_4x
fun:crypto_sign_signature_ctx
fun:pqcrystals_ml_dsa*_avx2_signature_internal
}
{
Rejection sampling for y
Memcheck:Value8
...
fun:pqcrystals_ml_dsa*_avx2_poly_uniform_gamma1m1_4x
fun:crypto_sign_signature_ctx
fun:pqcrystals_ml_dsa*_avx2_signature_internal
}
{
Rejection sampling for s1 and s2
Expand All @@ -65,15 +65,15 @@
...
fun:pqcrystals_ml_dsa*_avx2_poly_uniform_gamma1m1_preinit
fun:pqcrystals_ml_dsa*_avx2_poly_uniform_gamma1m1
fun:crypto_sign_signature_ctx
fun:pqcrystals_ml_dsa*_avx2_signature_internal
}
{
Rejection sampling for y
Memcheck:Value8
...
fun:pqcrystals_ml_dsa*_avx2_poly_uniform_gamma1m1_preinit
fun:pqcrystals_ml_dsa*_avx2_poly_uniform_gamma1m1
fun:crypto_sign_signature_ctx
fun:pqcrystals_ml_dsa*_avx2_signature_internal
}
{
Rejection sampling for challenge
Expand All @@ -89,56 +89,56 @@
Rejection sampling for signature distribution
Memcheck:Cond
...
src:sign.c:253 # Call to poly_chknorm
src:sign.c:248 # Call to poly_chknorm
# fun:pqcrystals_ml_dsa*_avx2_signature
}
{
Rejection sampling for signature distribution
Memcheck:Cond
...
src:sign.c:268 # Call to poly_chknorm
src:sign.c:263 # Call to poly_chknorm
# fun:pqcrystals_ml_dsa*_avx2_signature
}
{
Rejection sampling for signature distribution
Memcheck:Cond
...
src:sign.c:275 # Call to poly_chknorm
src:sign.c:270 # Call to poly_chknorm
# fun:pqcrystals_ml_dsa*_avx2_signature
}
{
Hint does not need to be computed in constant time
Memcheck:Cond
...
fun:pqcrystals_ml_dsa*_avx2_poly_make_hint
src:sign.c:279 # fun:pqcrystals_ml_dsa*_ref_signature
src:sign.c:274 # fun:pqcrystals_ml_dsa*_avx2_signature
}
{
Hint does not need to be computed in constant time
Memcheck:Value8
...
fun:pqcrystals_ml_dsa*_avx2_poly_make_hint
src:sign.c:279 # fun:pqcrystals_ml_dsa*_ref_signature
src:sign.c:274 # fun:pqcrystals_ml_dsa*_avx2_signature
}
{
Rejection sampling for hint
Memcheck:Cond
...
src:sign.c:280 # Checking number of 1 bits in hint
src:sign.c:275 # Checking number of 1 bits in hint
# fun:pqcrystals_ml_dsa*_avx2_signature
}
{
Hint positions are not secret
Memcheck:Cond
...
src:sign.c:284 # memcpy
src:sign.c:279 # memcpy
# fun:pqcrystals_ml_dsa*_avx2_signature
}
{
Hint positions are not secret
Memcheck:Value8
...
src:sign.c:284 # memcpy
src:sign.c:279 # memcpy
# fun:pqcrystals_ml_dsa*_avx2_signature
}
{
Expand All @@ -150,6 +150,6 @@
{
Verification is not done in constant time
Memcheck:Cond
fun:pqcrystals_ml_dsa*_avx2_verify
fun:pqcrystals_ml_dsa*_avx2_verify_internal
}

0 comments on commit 420e87e

Please sign in to comment.