Add search capabilities and common-mrw versioning metadata to serverwiz #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…group, field name, etc.
…arch for exact match. This both applies to searching the tree as well as searching the table
Also fixes exception generated after switching tabs, then searching for the same text.
…eature Search feature
…rsions Part versions
…f when starting the program
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In discussion with serverwiz users two key issues were identified:
(1) Finding specific entries/attributes in the tree view of the System MRW was not possible. Users would often have to grep the resulting XML for entries. This also led to users editing the XMLs directly - which was error-prone.
(2) Produced System MRW XML files provided no information about the version of the common-mrw that parts were pulled from. For example, if a consumer of a System MRW identified an error in a part, they would have no idea if that part came from the current common-mrw or if it was outdated. Since a System MRW could have used multiple versions of the common-mrw it becomes almost impossible to track what is happening.
Changes:
(1) A search tab is added to the top of the GUI which allows the user to search inside the tree view for specific part names, part attributes, attribute values. For example, one could search for a part name and then update an attribute value immediately.
(2) When a part is created from the common-mrw, serverwiz will query the git repository for the current commit hash (of the entire repo). This hash is added as metadata to the part and is displayed in the serverwiz GUI.
Parts from MRWs created prior to this change will NOT have a hash in their metadata and serverwiz will not add one. Only new parts add after this change will have a hash.
Because parts can be dependent on multiple files in common-mrw, the decision was made to use the overarching repository hash.