deps: bump various opentelemetry modules and golangci-lint #7175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
force-pushed
the
sr/bump-otel
branch
from
a8f6ffe
to
cca332f
Compare
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
srenatus
force-pushed
the
sr/bump-otel
branch
7 times, most recently
from
db988ec
to
1955470
Compare
srenatus
force-pushed
the
sr/bump-otel
branch
from
1955470
to
c2e8efb
Compare
srenatus
changed the title
srenatus
force-pushed
the
sr/bump-otel
branch
from
c2e8efb
to
2a57f71
Compare
srenatus
commented
Nov 14, 2024
| @@ -1,6 +1,9 @@ | |||
| run: | |||
| timeout: 5m | |||
|
|
|||
| issues: | |||
| max-same-issues: 0 # don't hide issues in CI runs because they are the same type | |||
There was a problem hiding this comment.
This is a small quality-of-life improvement, I hope: Previously, if the linter found a total of 5 issues, but they all had the same type, it wouldn't show you all of them. Now, we ask it to just spit it all out, all at once.
srenatus
commented
Nov 14, 2024
| @@ -28,7 +28,7 @@ ifeq ($(WASM_ENABLED),1) | |||
| GO_TAGS = -tags=opa_wasm | |||
| endif | |||
|
|
|||
| GOLANGCI_LINT_VERSION := v1.59.1 | |||
| GOLANGCI_LINT_VERSION := v1.60.1 | |||
There was a problem hiding this comment.
That's the aforementioned middle-ground: It works with our go version, but doesn't bring in too many new rules.
srenatus
commented
Nov 14, 2024
| @@ -392,7 +392,7 @@ func eval(args []string, params evalCommandParams, w io.Writer) (bool, error) { | |||
| for _, t := range timers { | |||
| val, ok := t[name].(int64) | |||
| if !ok { | |||
| return false, fmt.Errorf("missing timer for %s" + name) | |||
There was a problem hiding this comment.
it's not all bad! this is a good find
ashutosh-narkar
previously approved these changes
Nov 14, 2024
srenatus
force-pushed
the
sr/bump-otel
branch
from
7419638
to
39e9f68
Compare
This release had a fix to avoid "superfluous call to WriteHeader" log lines: https://github.com/open-telemetry/opentelemetry-go-contrib/releases/tag/v1.30.0 And there are further fixes in the releases we hadn't pulled in. Feels like a good idea to update this once in a while. Signed-off-by: Stephan Renatus <[email protected]>
The previous version has been failing without any good reason for me, so let's try this. About the version pick: It's not the latest version (v1.62.0 at the moment), because that would introduce a new revive rule, redeclares-builtin-id, and that flags every variable called `min` or `max` in the code base. I had started addressing these, but they were just too many. The new issues related to this version are mostly that it complains whenever it finds a non-static string that makes its way into a printf- like function. However, that's a common pattern in some place here, so I've sprinkled some nolint:govet on it. Signed-off-by: Stephan Renatus <[email protected]>
srenatus
force-pushed
the
sr/bump-otel
branch
from
39e9f68
to
bf91031
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release had a fix to avoid "superfluous call to WriteHeader" log lines:
https://github.com/open-telemetry/opentelemetry-go-contrib/releases/tag/v1.30.0
And there are further fixes in the releases we hadn't pulled in. Feels like a good idea to update this once in a while.
Re: Golangci-lint
The previous version has been failing without any good reason for me,
so let's try this one.
About the version pick: It's not the latest version (v1.62.0 at the
moment), because that would introduce a new revive rule,
redeclares-builtin-id, and that flags every variable called
minormaxin the code base. I had started addressing these, but they werejust too many. Also I hadn't found a working way to disable said rule.
The new issues related to this version are mostly that it complains
whenever it finds a non-static string that makes its way into a printf-
like function. However, that's a common pattern in some place here, so
I've sprinkled some
//nolint:goveton it.When this goes in, please rebase, to keep the two commits separate.