-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: use -bullseye golang image #6063
Merged
johanfylling
merged 1 commit into
open-policy-agent:main
from
srenatus:sr/build/bullseye
Jun 29, 2023
Merged
build: use -bullseye golang image #6063
johanfylling
merged 1 commit into
open-policy-agent:main
from
srenatus:sr/build/bullseye
Jun 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephan Renatus <[email protected]>
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This PR:
main:
TBH this output doesn't help me much. But I've verified that the binaries built from this PR run on the old gcr.io/distroless/cc image, where the ones from
|
johanfylling
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this, bumping the golang image used for building our release binaries changed our glibc lowest-possible-version inadvertently. This will turn that back.
At some point in the future, when a new debian release is out, the support for bullseye is going to be dropped, but we'll notice when trying to update Golang.