Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Setting pubsub annotations using --set in makefile #3160

Merged
merged 9 commits into from
Jan 31, 2024

Conversation

JaydipGabani
Copy link
Contributor

What this PR does / why we need it: Improving logical condition to set dapr annotations when pubsub is enabled and annotations are provided.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

@JaydipGabani JaydipGabani requested a review from a team as a code owner November 18, 2023 01:22
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3194281) 54.48% compared to head (918fba8) 54.46%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3160      +/-   ##
==========================================
- Coverage   54.48%   54.46%   -0.03%     
==========================================
  Files         134      134              
  Lines       12329    12329              
==========================================
- Hits         6718     6715       -3     
- Misses       5117     5120       +3     
  Partials      494      494              
Flag Coverage Δ
unittests 54.46% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we setting annotations for a third-party project in our helm file?

IMO, This should be removed or replaced with a project-neutral mechanism for setting annotations (I believe we can already set annotations in the config file?)

PubSub being in alpha would justify the removal

@maxsmythe
Copy link
Contributor

To be clear, we avoid any mention of third-party projects in our configs (Prometheus, cert-manager, etc.), because we don't want to take on the responsibility of making sure they are current.

Embedded dependencies are unavoidable in the case of golang libraries (e.g. metrics exporters), but in that case, we also have gomod/semver and (IIRC), don't have any config knobs other than those we implement directly.

@maxsmythe
Copy link
Contributor

Misread the current state: this proposal is to add pubsub directly to the Helm file (currently the annotations are in the Makefile for testing, which is fine).

We should not add these annotations to Helm for the reasons stated above.

@JaydipGabani JaydipGabani changed the title chore: Setting dapr annotations only when pubsub is enabled chore: Setting pubsub annotations only when pubsub is enabled Nov 21, 2023
@JaydipGabani
Copy link
Contributor Author

@maxsmythe based on your last comment we are good to merge this change then? since this PR does not add add anything related to dapr annotations in helm file.

@JaydipGabani JaydipGabani changed the title chore: Setting pubsub annotations only when pubsub is enabled chore: Setting pubsub annotations using --set in makefile Dec 11, 2023
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaydipGabani JaydipGabani merged commit ef1ebff into open-policy-agent:master Jan 31, 2024
16 checks passed
@JaydipGabani JaydipGabani deleted the pubsub-helm branch January 31, 2024 00:15
leewoobin789 pushed a commit to softlee-io/gatekeeper that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants