chore: linting

document/metadata.go

@@ -2,11 +2,12 @@ package document
 
 import (
 	"fmt"
-	"github.com/open-policy-agent/opa/ast"
-	"github.com/open-policy-agent/opa/loader"
 	"os"
 	"path/filepath"
 	"strings"
+
+	"github.com/open-policy-agent/opa/ast"
+	"github.com/open-policy-agent/opa/loader"
 )
 
 // ParseRegoWithAnnotations parse the rego in the indicated directory

document/metadata_test.go

@@ -2,11 +2,12 @@ package document
 
 import (
 	"fmt"
+	"testing"
+
 	"github.com/google/go-cmp/cmp"
 	"github.com/open-policy-agent/opa/ast"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
-	"testing"
 )
 
 func validateAnnotation(t *testing.T, as ast.FlatAnnotationsRefSet, want []string) {
@@ -51,7 +52,6 @@ func PartialEqual(t *testing.T, expected, actual any, diffOpts cmp.Option, msgAn
 	assert.Fail(t, fmt.Sprintf("Not equal: \n"+
 		"expected: %s\n"+
 		"actual  : %s%s", expected, actual, diff), msgAndArgs...)
-	return
 }
 
 func TestGetAnnotations(t *testing.T) {

document/template.go

@@ -75,7 +75,7 @@ func renderTemplate(tpl *TemplateConfig, args interface{}, out io.Writer) error
 			return err
 		}
 	default:
-		return fmt.Errorf("unknown template kind: %s", tpl.kind)
+		return fmt.Errorf("unknown template kind: %v", tpl.kind)
 	}
 
 	// we render the template

document/template_test.go

@@ -2,10 +2,11 @@ package document
 
 import (
 	"bytes"
-	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
 	"os"
 	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 )
 
 func Test_generateDocument(t *testing.T) {
@@ -52,7 +53,9 @@ func Test_generateDocument(t *testing.T) {
 				assert.Equal(t, string(wantOut), gotOut.String())
 
 				// prospective golden file, much simpler to see what's the result in case the test fails
-				os.WriteFile(tt.wantOut+".golden", gotOut.Bytes(), 0644)
+				// this does not override the existing test, but create a new file called xxx.golden
+				err = os.WriteFile(tt.wantOut+".golden", gotOut.Bytes(), 0600)
+				assert.NoError(t, err)
 			},
 		)
 	}

internal/commands/document.go

@@ -2,11 +2,12 @@ package commands
 
 import (
 	"fmt"
-	"github.com/open-policy-agent/conftest/document"
-	"github.com/spf13/cobra"
 	"log"
 	"os"
 	"path/filepath"
+
+	"github.com/open-policy-agent/conftest/document"
+	"github.com/spf13/cobra"
 )
 
 func NewDocumentCommand() *cobra.Command {
@@ -55,6 +56,9 @@ func NewDocumentCommand() *cobra.Command {
 				}(f)
 
 				template, err := cmd.Flags().GetString("template")
+				if err != nil {
+					return fmt.Errorf("invalid template: %s", err)
+				}
 
 				err = document.GenerateDocument(path, template, f)
 				if err != nil {