[RFC] Insert right objects before the left ones #152
+43
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss remaining siblings When we found where we should be inserted, we have to look at next sibling in case they should become children. No need to go till the last children: Once the first cpuset bit of a children is above out last, we're done. Mostly useful when inserting in reverse-cpuset-order.
…creation time The core inserts new objects within children by walking the existing children list from left to right. So insert the left children last is more efficient since it doesn't walk the entire list anymore. Otherwise, the overall complexity is quadratic with the number of children below objects. lstopo -i "pu:10000" goes down from 20s to 0.8s on my laptop. lstopo -i "100 100" is only improved by 1-2%. On real/existing platforms (KNL or 768pu-AltixUV), the impact seems negligible.
bgoglin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not really useful as long as we don't have hundreds of children within a single object. The quadratic complexity is negligible on current machines since we usually have tens of children max. Mostly useful for large synthetic topologies so far.
Check whether the first commit in the PR decreases performance before merging.
Otherwise just keep that code here until machines really need that sort of optimization. The Linux backend will need a reverse foreach loop.