Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for mmcv 2.1.0 to fix install on colab #937

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jolesinski
Copy link

Motivation

Installation of mmcv<2.1.0 is broken on Colab environment. Allow for mmcv version 2.1.0 in requirements, no issues observed when using that version.

Fixes #924
Fixes #922

Modification

Changed mmcv <2.1.0 constraint to <=2.1.0.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a potential influence on downstream projects, this PR should be tested with downstream projects, like MMDetection or MMClassification.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

Installation of mmcv<2.1.0 is broken on Colab environment.
Allow for mmcv version 2.1.0 in requirements, no issues
observerd when using that version.
@CLAassistant
Copy link

CLAassistant commented Nov 30, 2023

CLA assistant check
All committers have signed the CLA.

@onuralpszr
Copy link

Hello,

Is there any update for this to get through, it is been a long while and that could nice addition to have and run in collab ? If is there anything needs to be done, I would like to help If possible

Thank you.

cc : @RangeKing

@jolesinski
Copy link
Author

jolesinski commented Feb 6, 2024 via email

@onuralpszr
Copy link

circle CI failing because of other version check not because what you did, If you check other PRs it is also failing because tests needs to be fix which require separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colab install as per custom_installation.md not functioning MMCV 2.1.0 support
3 participants