Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add autoanchor for YOLO series #654

Open
wants to merge 20 commits into
base: dev
Choose a base branch
from

Conversation

yechenzhi
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation for this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a potential influence on downstream projects, this PR should be tested with downstream projects, like MMDetection or MMClassification.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@PeterH0323 PeterH0323 changed the title add autoanchor for yolo series(with bug) [Feature] Add autoanchor for YOLO series (with bug) Mar 15, 2023
@yechenzhi yechenzhi changed the title [Feature] Add autoanchor for YOLO series (with bug) [Feature] Add autoanchor for YOLO series Mar 18, 2023

priority = 48

# YOLOAutoAnchorHook takes priority over EMAHook.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

既然有这个要求,那么在这个hook初始化时候一定要记得打印下,说明这个hook优先级必须高于 emahook,提供更多信息

model = model.module

device = next(model.parameters()).device
anchors = torch.tensor(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个地方应该用 model 内部属性比较好,而不是用配置。而且要写的鲁棒点

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接用model.bbox_head.prior_generator.base_sizes 这样可以嘛?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants