[Fix] fix infer.py _init_collate incompatibility problem #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouzaida
reviewed
Sep 19, 2023
Comment on lines
+532
to
+547
| collate_fn_cfg = cfg.test_dataloader.collate_fn | ||
| if isinstance(collate_fn_cfg, dict): | ||
| collate_fn_type = collate_fn_cfg.pop('type') | ||
| if isinstance(collate_fn_type, str): | ||
| collate_fn = registry.get(collate_fn_type) | ||
| else: | ||
| collate_fn = collate_fn_type | ||
| from functools import partial | ||
| collate_fn = partial(collate_fn, | ||
| **collate_fn_cfg) # type: ignore | ||
| elif callable(collate_fn_cfg): | ||
| collate_fn = collate_fn_cfg | ||
| else: | ||
| raise TypeError( | ||
| 'collate_fn should be a dict or callable object, ' | ||
| f'but got {collate_fn_cfg}') |
There was a problem hiding this comment.
We can move the changes here to build_collate_fn, and at the same time, the logic in build_dataloader can replace with this function.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1360 +/- ##
=======================================
Coverage ? 70.38%
=======================================
Files ? 153
Lines ? 14219
Branches ? 2956
=======================================
Hits ? 10008
Misses ? 3748
Partials ? 463
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
I customized a collated_fn, use cfg collated_fn = dict(type='xxx', *args) before.
but when i update mmengine, my program will raise an error about "The key argument of
Registry.getmust be a str"Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist