Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeCamp2023-287] Add DVCLiveVisBackend #1336

Merged
merged 20 commits into from
Sep 8, 2023

Conversation

RangeKing
Copy link
Contributor

@RangeKing RangeKing commented Sep 1, 2023

Motivation

Add DVCLiveVisBackend

Note:
The latest vesion of dvclive in Python 3.7 is 0.9.0 which doesn't support log_param and log_params.
Therefore, Python version should be 3.8 or higher version to use DVCLiveVisBackend.

@zhouzaida
Copy link
Collaborator

Could you help update the usage document in docs/zh_cn/common_usage/visualize_training_log.md and docs/en/common_usage/visualize_training_log.md?

@zhouzaida zhouzaida added this to the 0.8.5 milestone Sep 4, 2023
@RangeKing
Copy link
Contributor Author

RangeKing commented Sep 4, 2023

Could you help update the usage document in docs/zh_cn/common_usage/visualize_training_log.md and docs/en/common_usage/visualize_training_log.md?

With pleasure.
Now there is a problem. DVC works best in a Git repository and most users run experiments in a OpenMMLab repo. But work_dirs/ is in the .gitignore file. Therefore DVC will give a warning WARNING:dvclive:Error in cache: bad DVC file name 'work_dirs\xxx.dvc' is git-ignored.

@zhouzaida
Copy link
Collaborator

Could you help update the usage document in docs/zh_cn/common_usage/visualize_training_log.md and docs/en/common_usage/visualize_training_log.md?

With pleasure. Now there is a problem. DVC works best in a Git repository and most users run experiments in a OpenMMLab repo. But work_dirs/ is in the .gitignore file. Therefore DVC will give a warning WARNING:dvclive:Error in cache: bad DVC file name 'work_dirs\xxx.dvc' is git-ignored.

How about opening an issue on dvclive?

@RangeKing RangeKing requested a review from C1rN09 as a code owner September 6, 2023 13:35
@RangeKing
Copy link
Contributor Author

@zhouzaida I wrote a note in document. Recommend not to set work_dir as work_dirs.
And this PR is almost done.

@zhouzaida
Copy link
Collaborator

@zhouzaida I wrote a note in document. Recommend not to set work_dir as work_dirs. And this PR is almost done.

OK

@zhouzaida zhouzaida merged commit 273fb2b into open-mmlab:main Sep 8, 2023
8 of 9 checks passed
@fanqiNO1 fanqiNO1 mentioned this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants