-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] The keyword mode appears nested multiple times in the log #1305
Conversation
Hi, do you mean that you configure |
Hi, I only set The variable mmengine/mmengine/runner/log_processor.py Line 296 in a483dba
|
mmengine/runner/log_processor.py
Outdated
data_src = f"{mode}/{data_src}" | ||
log_name = f"{mode}/{log_name}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data_src = f"{mode}/{data_src}" | |
log_name = f"{mode}/{log_name}" | |
data_src = f'{mode}/{data_src}' | |
log_name = f'{mode}/{log_name}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah-ha! Indeed, that's the case. Thank you for your contribution. We'll merge ASAP after lint is fixed.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
When
log_with_hierarchy
is set to True, the keywordmode
appears nested multiple times in the log. For example, val/val/data_time: 0.0332 val/val/time: 0.4490.Modification
mmengine/mmengine/runner/log_processor.py
Line 379 in a483dba
to
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist