Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] The keyword mode appears nested multiple times in the log #1305

Merged
merged 3 commits into from
Sep 9, 2023

Conversation

huaibovip
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

When log_with_hierarchy is set to True, the keyword mode appears nested multiple times in the log. For example, val/val/data_time: 0.0332 val/val/time: 0.4490.
bug_val

Modification

for log_cfg in custom_cfg:

        for log_cfg in custom_cfg:
            if not reserve_prefix:
                data_src = log_cfg.pop('data_src')
                log_name = f"{log_cfg.pop('log_name', data_src)}"
            else:
                data_src = f"{mode}/{log_cfg.pop('data_src')}"
                log_name = f"{mode}/{log_cfg.pop('log_name', data_src)}"

to

        for log_cfg in custom_cfg:
            data_src = log_cfg.pop('data_src')
            log_name = f"{log_cfg.pop('log_name', data_src)}"
            if reserve_prefix:
                data_src = f"{mode}/{data_src}"
                log_name = f"{mode}/{log_name}"

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@huaibovip huaibovip requested a review from HAOCHENYE as a code owner August 14, 2023 01:10
@HAOCHENYE
Copy link
Collaborator

Hi, do you mean that you configure custom_cfg and set log_with_hierarchy to true simultaneously? The code snippet you modified only works when custom_cfg is configured.

@huaibovip
Copy link
Contributor Author

huaibovip commented Aug 14, 2023

@HAOCHENYE

Hi, I only set log_with_hierarchy=True, while keeping custom_cfg default, besides I use EpochBased mode.

The variable custom_cfg gets assigned here, so the code I changed takes effect.

if 'time' not in custom_keys:

Comment on lines 383 to 384
data_src = f"{mode}/{data_src}"
log_name = f"{mode}/{log_name}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
data_src = f"{mode}/{data_src}"
log_name = f"{mode}/{log_name}"
data_src = f'{mode}/{data_src}'
log_name = f'{mode}/{log_name}'

HAOCHENYE
HAOCHENYE previously approved these changes Aug 14, 2023
Copy link
Collaborator

@HAOCHENYE HAOCHENYE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah-ha! Indeed, that's the case. Thank you for your contribution. We'll merge ASAP after lint is fixed.

@zhouzaida zhouzaida changed the title fix log_processor.py [Fix] The keyword mode appears nested multiple times in the log Sep 9, 2023
@zhouzaida zhouzaida merged commit 00df73c into open-mmlab:main Sep 9, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants