Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation on musl libc #664

Merged
merged 5 commits into from
Jul 14, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions api.c
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@
#include "libtcmu_priv.h"
#include "be_byteshift.h"

__thread int __tcmu_is_ework_thread = 0;

int tcmu_cdb_get_length(uint8_t *cdb)
{
uint8_t group_code = cdb[0] >> 5;
Expand Down Expand Up @@ -74,7 +76,7 @@ uint64_t tcmu_cdb_get_lba(uint8_t *cdb)
case 16:
return be64toh(*((u_int64_t *)&cdb[2]));
default:
assert_perror(EINVAL);
assert(0);
return 0; /* not reached */
}
}
Expand All @@ -91,7 +93,7 @@ uint32_t tcmu_cdb_get_xfer_length(uint8_t *cdb)
case 16:
return be32toh(*((u_int32_t *)&cdb[10]));
default:
assert_perror(EINVAL);
assert(0);
return 0; /* not reached */
}
}
Expand Down
8 changes: 2 additions & 6 deletions libtcmu.c
Original file line number Diff line number Diff line change
Expand Up @@ -843,24 +843,20 @@ const char *tcmu_dev_get_uio_name(struct tcmu_device *dev)
void tcmu_set_thread_name(const char *prefix, struct tcmu_device *dev)
{
const char *uio = dev ? tcmu_dev_get_uio_name(dev) : NULL;
char cname[TCMU_THREAD_NAME_LEN];
char *pname;

if (pthread_getname_np(pthread_self(), cname, TCMU_THREAD_NAME_LEN))
return;

/*
* If we are trying to set the pthread name in the
* event work thread, we must ignore it.
*/
if (!strcmp(cname, "ework-thread")) {
if (__tcmu_is_ework_thread) {
tcmu_dev_warn(dev, "Do not set name for event work thread in the callback fn\n");
return;
}

if (!prefix) {
tcmu_dev_err(dev, "Failed to set name for thread %lu\n",
pthread_self());
(long unsigned int)pthread_self());
return;
}

Expand Down
3 changes: 3 additions & 0 deletions libtcmu_common.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#define __LIBTCMU_COMMON_H

#include <stdbool.h>
#include <pthread.h>

#ifdef __cplusplus
extern "C" {
Expand Down Expand Up @@ -193,6 +194,8 @@ void __tcmu_sense_set_data(uint8_t *sense_buf, uint8_t key, uint16_t asc_ascq);
*/
void tcmu_thread_cancel(pthread_t thread);

extern __thread int __tcmu_is_ework_thread;

#ifdef __cplusplus
}
#endif
Expand Down
6 changes: 1 addition & 5 deletions libtcmu_log.c
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,6 @@ static int output_to_fd(int pri, const char *timestamp,
int fd = (intptr_t) data;
char *buf, *msg;
int count, ret, written = 0, r, pid = 0;
char pname[TCMU_THREAD_NAME_LEN];

if (fd == -1)
return -1;
Expand All @@ -412,13 +411,10 @@ static int output_to_fd(int pri, const char *timestamp,
if (pid <= 0)
return -1;

if (pthread_getname_np(pthread_self(), pname, TCMU_THREAD_NAME_LEN))
return -1;

/*
* format: timestamp pid [loglevel] msg
*/
ret = asprintf(&msg, "%s %d:%s [%s] %s", timestamp, pid, pname,
ret = asprintf(&msg, "%s %d [%s] %s", timestamp, pid,
loglevel_string(pri), str);
if (ret < 0)
return -1;
Expand Down
8 changes: 4 additions & 4 deletions main.c
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,7 @@ int tcmur_get_time(struct tcmu_device *dev, struct timespec *time)

ret = clock_gettime(CLOCK_MONOTONIC_COARSE, time);
if (!ret) {
tcmu_dev_dbg(dev, "Current time %lu secs.\n", time->tv_sec);
JuniorJPDJ marked this conversation as resolved.
Show resolved Hide resolved
tcmu_dev_dbg(dev, "Current time %"PRIdMAX" secs.\n", (intmax_t)time->tv_sec);
return 0;
}

Expand Down Expand Up @@ -700,9 +700,9 @@ static bool get_next_cmd_timeout(struct tcmu_device *dev,
tmo->tv_sec = 0;
}

tcmu_dev_dbg(dev, "Next cmd id %hu timeout in %lu secs. Current time %lu. Start time %lu\n",
tcmur_cmd->lib_cmd->cmd_id, tmo->tv_sec,
curr_time->tv_sec, tcmur_cmd->start_time.tv_sec);
tcmu_dev_dbg(dev, "Next cmd id %hu timeout in %"PRIdMAX" secs. Current time %"PRIdMAX". Start time %"PRIdMAX"\n",
tcmur_cmd->lib_cmd->cmd_id, (intmax_t)tmo->tv_sec,
(intmax_t)curr_time->tv_sec, (intmax_t)tcmur_cmd->start_time.tv_sec);
break;
}
pthread_spin_unlock(&rdev->lock);
Expand Down
8 changes: 2 additions & 6 deletions tcmur_work.c
Original file line number Diff line number Diff line change
Expand Up @@ -41,16 +41,11 @@ struct tcmur_work *tcmur_create_work(void)

static void __tcmur_flush_work(struct tcmur_work *work)
{
char pname[TCMU_THREAD_NAME_LEN];

if (pthread_getname_np(pthread_self(), pname, TCMU_THREAD_NAME_LEN))
return;

/*
* The event work thread may need to do a handler reopen
* call and try to flush itself. Just ignore.
*/
if (!strcmp(pname, "ework-thread"))
if (__tcmu_is_ework_thread)
JuniorJPDJ marked this conversation as resolved.
Show resolved Hide resolved
return;

/*
Expand Down Expand Up @@ -79,6 +74,7 @@ static void *tcmur_work_fn(void *data)
struct private *p = data;

tcmu_set_thread_name("ework-thread", NULL);
__tcmu_is_ework_thread = 1;

p->work_fn(p->data);

Expand Down