Raunak/gas griefing fixes

[RnkSngh]

PR to fix the gas griefing vuln in dispatcher contract by checking that gasLeft is still > 1/64 of what the low level call took

Summary by CodeRabbit

• New Features

  • Improved gas management in blockchain transactions to ensure sufficient gas is available post-transaction.
  • Introduced error handling for scenarios with insufficient gas during transactions.

• Tests

  • Added tests for gas management and behavior under gas-constrained conditions in blockchain interactions.

[coderabbitai]

Walkthrough

The recent updates aim to bolster gas management and error handling in smart contracts for Inter-Blockchain Communication (IBC). A gas check safeguard is now in place in Dispatcher.sol to verify post-execution gas levels. Furthermore, error handling is enhanced with the notEnoughGas() error, and new test configurations are introduced to evaluate and address potential gas griefing scenarios in IBC setups.

Changes

Files	Change Summary
contracts/core/Dispatcher.sol, contracts/libs/Ibc.sol	Added gas check in Dispatcher.sol; Introduced notEnoughGas() error in IBCErrors library.
test/.../Dispatcher.gasGriefing.sol, test/mocks/GasUsingMars.sol	Implemented gas griefing tests in IBC scenarios; Added mock contract for gas usage simulation.

🐰✨
Oh, in the realm of code and lore,
Changes abound, improvements galore!
With each line finely sewn,
Gas checks now well-known,
A rabbit hops, pleased, evermore! 🌟🚀

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 89ddc8d and 486d3e7.

Files selected for processing (3)

• contracts/core/Dispatcher.sol (1 hunks)
• test/Dispatcher.gasGriefing.t.sol (1 hunks)
• test/mocks/GasUsingMars.sol (1 hunks)

Files skipped from review as they are similar to previous changes (2)

• contracts/core/Dispatcher.sol
• test/mocks/GasUsingMars.sol

Additional comments not posted (3)

test/Dispatcher.gasGriefing.t.sol (3)

4-7: The import statements are correctly placed and necessary for the functionality of the test contract.

---

21-25: The contract setup in setUp is correctly implemented. Consider clarifying the comment about gas usage to explain why a high gas value is set for the GasUsingMars contract.

---

27-39: The test_GasGriefing function correctly simulates a gas griefing scenario. Consider adding detailed comments to explain the test scenario, the setup of the packet, and the expected outcomes for better readability and maintainability.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[dshiell]

lgtm, just wondering about if the gas check should be "<="

[alfredo-stonk]

Change looks good!
Need to fix forge test though

[RnkSngh]

Need to fix forge test though

Should be fixed now! Seemed to be a problem with my local os being non-case sensitive but the CI being case sensitive

[reednaa]

Lgtm. Thanks for the fix.