Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ics-29 and incentivized ack #15

Merged
merged 17 commits into from
Aug 28, 2023
Merged

ics-29 and incentivized ack #15

merged 17 commits into from
Aug 28, 2023

Conversation

alfredo-stonk
Copy link
Member

@alfredo-stonk alfredo-stonk commented Jul 27, 2023 •
edited
Loading

add support for ics-29 packet fee

@alfredo-stonk alfredo-stonk mentioned this pull request Jul 27, 2023
Merged
@alfredo-stonk Graphite App
Copy link
Member Author

alfredo-stonk commented Jul 27, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@alfredo-stonk alfredo-stonk marked this pull request as ready for review August 9, 2023 03:13
dshiell
dshiell approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@dshiell dshiell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a couple questions. very nice!

contracts/Dispatcher.sol Outdated Show resolved Hide resolved
contracts/Dispatcher.sol Outdated Show resolved Hide resolved
contracts/Dispatcher.sol Outdated Show resolved Hide resolved
contracts/Mars.sol Show resolved Hide resolved
@alfredo-stonk alfredo-stonk force-pushed the ww/ics-29 branch 2 times, most recently from bbce638 to 85e21be Compare August 18, 2023 15:49
Base automatically changed from ww/encoding to main August 18, 2023 15:57
WenweiX added 16 commits August 28, 2023 13:50
add tests for payPacketFeeAsync
b726ac6
test custom ack packets encoding and hash
de96318
create FeeTest contract for all packet fee related tests
8a3e7e7
add deriveAddress and remove integer-based temp addresses
a2f8041
add test for non-incentivized ack
289e537
change relayer from string to bytes in IncentivizedAck
8fa66b3
impl escrow functions for ics-29
3f8c6b0
support refund extra packet fee
2c30a61
distribute timeout packet fee and refund
163a3c4 
add Ibc library for code reuse
add more test cases for ack packet fees
98bbe85
more tests for payPacketFeeAsync and timeout fee
c14eec5
fix rebase conflicts
3c43bf4
move Escrow contract to a separate file
187e17f
require strong type checking of Escrow in Dispatcher contract
c743719
fix typo; clarify Mars.receive
a9b17c7
remove dup checks
909c4c1
@alfredo-stonk alfredo-stonk merged commit 78c3168 into main Aug 28, 2023
1 check passed
@alfredo-stonk alfredo-stonk deleted the ww/ics-29 branch August 28, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshiell dshiell dshiell approved these changes

@nicopernas nicopernas nicopernas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alfredo-stonk @nicopernas @dshiell