add licensing info #103
add licensing info #103
Conversation
|
Warning Rate Limit Exceeded@RnkSngh has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 46 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe update involves transitioning various files to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (4)
contracts/base/GeneralMiddleware.sol (4)
Line range hint
21-21: Remove unused import to clean up the code.- import {Ibc, UniversalPacket, AckPacket} from "../libs/Ibc.sol"; + import {UniversalPacket, AckPacket} from "../libs/Ibc.sol";
Line range hint
48-48: Variable names should follow mixedCase naming convention.- uint256 public MW_ID; + uint256 public mwId;
Line range hint
66-66: Consider adding named parameters to improve code readability and maintainability.Also applies to: 77-77, 96-96, 125-125, 142-142, 155-155
Line range hint
175-175: Avoid leaving empty function bodies as they can lead to maintenance issues. Consider implementing the function or explicitly noting it's intentionally left empty.- function onTimeoutUniversalPacket(bytes32 channelId, UniversalPacket calldata packet) external override onlyIbcMw {} + function onTimeoutUniversalPacket(bytes32 channelId, UniversalPacket calldata packet) external override onlyIbcMw { + // TODO: Implement or explicitly note why this is left empty + }
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (25)
- LICENSE (1 hunks)
- contracts/base/GeneralMiddleware.sol (1 hunks)
- contracts/core/Dispatcher.sol (1 hunks)
- contracts/core/OptimisticLightClient.sol (1 hunks)
- contracts/core/OptimisticProofVerifier.sol (1 hunks)
- contracts/core/UniversalChannelHandler.sol (1 hunks)
- contracts/examples/Earth.sol (1 hunks)
- contracts/examples/Mars.sol (1 hunks)
- contracts/interfaces/IDispatcher.sol (1 hunks)
- contracts/interfaces/ILightClient.sol (1 hunks)
- contracts/interfaces/IProofVerifier.sol (1 hunks)
- contracts/interfaces/IUniversalChannelHandler.sol (1 hunks)
- contracts/interfaces/IbcDispatcher.sol (1 hunks)
- contracts/interfaces/IbcMiddleware.sol (1 hunks)
- contracts/interfaces/IbcReceiver.sol (1 hunks)
- contracts/interfaces/IbcReceiverUpgradeable.sol (1 hunks)
- contracts/libs/Ibc.sol (1 hunks)
- contracts/libs/IbcErrors.sol (1 hunks)
- contracts/libs/IbcUtils.sol (1 hunks)
- contracts/utils/DummyLightClient.sol (1 hunks)
- contracts/utils/DummyProofVerifier.sol (1 hunks)
- contracts/utils/GasAudit.sol (1 hunks)
- test/upgradeableProxy/upgrades/DispatcherV2.sol (1 hunks)
- test/upgradeableProxy/upgrades/DispatcherV2Initializable.sol (1 hunks)
- test/utils/TestUtils.t.sol (1 hunks)
Files skipped from review due to trivial changes (21)
- LICENSE
- contracts/core/Dispatcher.sol
- contracts/core/OptimisticLightClient.sol
- contracts/core/UniversalChannelHandler.sol
- contracts/examples/Earth.sol
- contracts/interfaces/IDispatcher.sol
- contracts/interfaces/ILightClient.sol
- contracts/interfaces/IProofVerifier.sol
- contracts/interfaces/IUniversalChannelHandler.sol
- contracts/interfaces/IbcDispatcher.sol
- contracts/interfaces/IbcMiddleware.sol
- contracts/interfaces/IbcReceiver.sol
- contracts/interfaces/IbcReceiverUpgradeable.sol
- contracts/libs/Ibc.sol
- contracts/libs/IbcUtils.sol
- contracts/utils/DummyLightClient.sol
- contracts/utils/DummyProofVerifier.sol
- contracts/utils/GasAudit.sol
- test/upgradeableProxy/upgrades/DispatcherV2.sol
- test/upgradeableProxy/upgrades/DispatcherV2Initializable.sol
- test/utils/TestUtils.t.sol
Additional Context Used
GitHub Check Runs (1)
lint failure (12)
contracts/base/GeneralMiddleware.sol: [warning] 21-21:
imported name Ibc is not used
contracts/base/GeneralMiddleware.sol: [warning] 48-48:
Variable name must be in mixedCase
contracts/base/GeneralMiddleware.sol: [warning] 66-66:
Named parameters missing. MIN unnamed argumenst is 4
contracts/base/GeneralMiddleware.sol: [warning] 77-77:
Named parameters missing. MIN unnamed argumenst is 4
contracts/base/GeneralMiddleware.sol: [warning] 80-80:
All public or external methods in a contract must override a definition from an interface
contracts/base/GeneralMiddleware.sol: [warning] 96-96:
Named parameters missing. MIN unnamed argumenst is 4
contracts/base/GeneralMiddleware.sol: [warning] 125-125:
Named parameters missing. MIN unnamed argumenst is 4
contracts/base/GeneralMiddleware.sol: [warning] 142-142:
Named parameters missing. MIN unnamed argumenst is 4
contracts/base/GeneralMiddleware.sol: [warning] 155-155:
Named parameters missing. MIN unnamed argumenst is 4
contracts/base/GeneralMiddleware.sol: [warning] 175-175:
Code contains empty blocks
Additional comments not posted (5)
contracts/libs/IbcErrors.sol (1)
1-1: SPDX license identifier updated to Apache-2.0.contracts/base/GeneralMiddleware.sol (2)
1-1: SPDX license identifier updated to Apache-2.0.
Line range hint
80-80: Ensure that all public or external methods override a definition from an interface to adhere to Solidity best practices.Verification successful
The script was successfully executed with the correct settings to handle the regex capabilities needed for the task. The absence of output from the script indicates that there are no public or external methods in the
GeneralMiddleware.solfile that fail to include theoverridekeyword where expected. This suggests that all such methods in this file properly override interface definitions, adhering to Solidity best practices.All public or external methods in
GeneralMiddleware.solcorrectly override interface definitions as per Solidity best practices.
- No issues were found in the methods' declarations regarding the use of the
overridekeyword.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that all public or external methods in `GeneralMiddleware.sol` properly override interface definitions. # Test: Search for public or external methods that do not override interface definitions. Expect: No occurrences. rg --type solidity --multiline $'function (.+?)\\(\\) (public|external)' contracts/base/GeneralMiddleware.solLength of output: 141
Script:
#!/bin/bash # Description: Verify that all public or external methods in `GeneralMiddleware.sol` properly override interface definitions. # Test: Search for public or external methods that do not override interface definitions. Expect: No occurrences. rg --multiline $'function (.+?)\\((.*?)\\) (public|external)(?!.*override)' contracts/base/GeneralMiddleware.solLength of output: 411
Script:
#!/bin/bash # Description: Verify that all public or external methods in `GeneralMiddleware.sol` properly override interface definitions. # Test: Search for public or external methods that do not override interface definitions. Expect: No occurrences. rg --pcre2 --multiline $'function (.+?)\\((.*?)\\) (public|external)(?!.*override)' contracts/base/GeneralMiddleware.solLength of output: 119
contracts/core/OptimisticProofVerifier.sol (1)
1-1: SPDX license identifier updated to Apache-2.0.contracts/examples/Mars.sol (1)
1-1: SPDX license identifier updated to Apache-2.0.
RnkSngh
force-pushed
the
raunak/spdx-licence
branch
2 times, most recently
from
8a98ab9 to
5edb1ab
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (4)
contracts/base/GeneralMiddleware.sol (4)
Line range hint
22-22: Remove the unused import to clean up the code.- import {Ibc, UniversalPacket, AckPacket} from "../libs/Ibc.sol"; + import {UniversalPacket, AckPacket} from "../libs/Ibc.sol";
Line range hint
49-49: Rename the variable to follow Solidity naming conventions.- uint256 public MW_ID; + uint256 public mwId;
Line range hint
67-67: Consider adding named parameters to improve code readability.- function sendUniversalPacket( + function sendUniversalPacket( + bytes32 channelId, + bytes32 destPortAddr, + bytes calldata appData, + uint64 timeoutTimestamp + ) external override {
Line range hint
176-176: Consider adding a comment to explain why this method body is empty, or implement the intended functionality.
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (25)
- LICENSE (1 hunks)
- contracts/base/GeneralMiddleware.sol (1 hunks)
- contracts/core/Dispatcher.sol (1 hunks)
- contracts/core/OptimisticLightClient.sol (1 hunks)
- contracts/core/OptimisticProofVerifier.sol (1 hunks)
- contracts/core/UniversalChannelHandler.sol (1 hunks)
- contracts/examples/Earth.sol (1 hunks)
- contracts/examples/Mars.sol (1 hunks)
- contracts/interfaces/IDispatcher.sol (1 hunks)
- contracts/interfaces/ILightClient.sol (1 hunks)
- contracts/interfaces/IProofVerifier.sol (1 hunks)
- contracts/interfaces/IUniversalChannelHandler.sol (1 hunks)
- contracts/interfaces/IbcDispatcher.sol (1 hunks)
- contracts/interfaces/IbcMiddleware.sol (1 hunks)
- contracts/interfaces/IbcReceiver.sol (1 hunks)
- contracts/interfaces/IbcReceiverUpgradeable.sol (1 hunks)
- contracts/libs/Ibc.sol (1 hunks)
- contracts/libs/IbcErrors.sol (1 hunks)
- contracts/libs/IbcUtils.sol (1 hunks)
- contracts/utils/DummyLightClient.sol (1 hunks)
- contracts/utils/DummyProofVerifier.sol (1 hunks)
- contracts/utils/GasAudit.sol (1 hunks)
- test/upgradeableProxy/upgrades/DispatcherV2.sol (1 hunks)
- test/upgradeableProxy/upgrades/DispatcherV2Initializable.sol (1 hunks)
- test/utils/TestUtils.t.sol (1 hunks)
Files skipped from review as they are similar to previous changes (24)
- LICENSE
- contracts/core/Dispatcher.sol
- contracts/core/OptimisticLightClient.sol
- contracts/core/OptimisticProofVerifier.sol
- contracts/core/UniversalChannelHandler.sol
- contracts/examples/Earth.sol
- contracts/examples/Mars.sol
- contracts/interfaces/IDispatcher.sol
- contracts/interfaces/ILightClient.sol
- contracts/interfaces/IProofVerifier.sol
- contracts/interfaces/IUniversalChannelHandler.sol
- contracts/interfaces/IbcDispatcher.sol
- contracts/interfaces/IbcMiddleware.sol
- contracts/interfaces/IbcReceiver.sol
- contracts/interfaces/IbcReceiverUpgradeable.sol
- contracts/libs/Ibc.sol
- contracts/libs/IbcErrors.sol
- contracts/libs/IbcUtils.sol
- contracts/utils/DummyLightClient.sol
- contracts/utils/DummyProofVerifier.sol
- contracts/utils/GasAudit.sol
- test/upgradeableProxy/upgrades/DispatcherV2.sol
- test/upgradeableProxy/upgrades/DispatcherV2Initializable.sol
- test/utils/TestUtils.t.sol
Additional Context Used
GitHub Check Runs (1)
lint failure (12)
contracts/base/GeneralMiddleware.sol: [warning] 22-22:
imported name Ibc is not used
contracts/base/GeneralMiddleware.sol: [warning] 49-49:
Variable name must be in mixedCase
contracts/base/GeneralMiddleware.sol: [warning] 67-67:
Named parameters missing. MIN unnamed argumenst is 4
contracts/base/GeneralMiddleware.sol: [warning] 78-78:
Named parameters missing. MIN unnamed argumenst is 4
contracts/base/GeneralMiddleware.sol: [warning] 81-81:
All public or external methods in a contract must override a definition from an interface
contracts/base/GeneralMiddleware.sol: [warning] 97-97:
Named parameters missing. MIN unnamed argumenst is 4
contracts/base/GeneralMiddleware.sol: [warning] 126-126:
Named parameters missing. MIN unnamed argumenst is 4
contracts/base/GeneralMiddleware.sol: [warning] 143-143:
Named parameters missing. MIN unnamed argumenst is 4
contracts/base/GeneralMiddleware.sol: [warning] 156-156:
Named parameters missing. MIN unnamed argumenst is 4
contracts/base/GeneralMiddleware.sol: [warning] 176-176:
Code contains empty blocks
Additional comments not posted (2)
contracts/base/GeneralMiddleware.sol (2)
1-18: The licensing information has been updated correctly to Apache-2.0.
Line range hint
81-81: Verify that this method overrides an interface definition or consider removing it if it's not used.
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (9)
contracts/base/GeneralMiddleware.sol (9)
Line range hint
22-22: The importIbcis not used in the file.- import {Ibc, UniversalPacket, AckPacket} from "../libs/Ibc.sol"; + import {UniversalPacket, AckPacket} from "../libs/Ibc.sol";
Line range hint
49-49: VariableMW_IDshould follow mixedCase naming convention.- uint256 public MW_ID; + uint256 public mwId;
Line range hint
67-67: Consider using named parameters for clarity in method calls.
Line range hint
78-78: Consider using named parameters for clarity in method calls.
Line range hint
97-97: Consider using named parameters for clarity in method calls.
Line range hint
126-126: Consider using named parameters for clarity in method calls.
Line range hint
143-143: Consider using named parameters for clarity in method calls.
Line range hint
156-156: Consider using named parameters for clarity in method calls.
Line range hint
176-176: Empty method implementations should be documented to explain why they are empty.
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (25)
- LICENSE (1 hunks)
- contracts/base/GeneralMiddleware.sol (1 hunks)
- contracts/core/Dispatcher.sol (1 hunks)
- contracts/core/OptimisticLightClient.sol (1 hunks)
- contracts/core/OptimisticProofVerifier.sol (1 hunks)
- contracts/core/UniversalChannelHandler.sol (1 hunks)
- contracts/examples/Earth.sol (1 hunks)
- contracts/examples/Mars.sol (1 hunks)
- contracts/interfaces/IDispatcher.sol (1 hunks)
- contracts/interfaces/ILightClient.sol (1 hunks)
- contracts/interfaces/IProofVerifier.sol (1 hunks)
- contracts/interfaces/IUniversalChannelHandler.sol (1 hunks)
- contracts/interfaces/IbcDispatcher.sol (1 hunks)
- contracts/interfaces/IbcMiddleware.sol (1 hunks)
- contracts/interfaces/IbcReceiver.sol (1 hunks)
- contracts/interfaces/IbcReceiverUpgradeable.sol (1 hunks)
- contracts/libs/Ibc.sol (1 hunks)
- contracts/libs/IbcErrors.sol (1 hunks)
- contracts/libs/IbcUtils.sol (1 hunks)
- contracts/utils/DummyLightClient.sol (1 hunks)
- contracts/utils/DummyProofVerifier.sol (1 hunks)
- contracts/utils/GasAudit.sol (1 hunks)
- test/upgradeableProxy/upgrades/DispatcherV2.sol (1 hunks)
- test/upgradeableProxy/upgrades/DispatcherV2Initializable.sol (1 hunks)
- test/utils/TestUtils.t.sol (1 hunks)
Files skipped from review as they are similar to previous changes (24)
- LICENSE
- contracts/core/Dispatcher.sol
- contracts/core/OptimisticLightClient.sol
- contracts/core/OptimisticProofVerifier.sol
- contracts/core/UniversalChannelHandler.sol
- contracts/examples/Earth.sol
- contracts/examples/Mars.sol
- contracts/interfaces/IDispatcher.sol
- contracts/interfaces/ILightClient.sol
- contracts/interfaces/IProofVerifier.sol
- contracts/interfaces/IUniversalChannelHandler.sol
- contracts/interfaces/IbcDispatcher.sol
- contracts/interfaces/IbcMiddleware.sol
- contracts/interfaces/IbcReceiver.sol
- contracts/interfaces/IbcReceiverUpgradeable.sol
- contracts/libs/Ibc.sol
- contracts/libs/IbcErrors.sol
- contracts/libs/IbcUtils.sol
- contracts/utils/DummyLightClient.sol
- contracts/utils/DummyProofVerifier.sol
- contracts/utils/GasAudit.sol
- test/upgradeableProxy/upgrades/DispatcherV2.sol
- test/upgradeableProxy/upgrades/DispatcherV2Initializable.sol
- test/utils/TestUtils.t.sol
Additional Context Used
GitHub Check Runs (1)
lint success (11)
contracts/base/GeneralMiddleware.sol: [warning] 22-22:
imported name Ibc is not used
contracts/base/GeneralMiddleware.sol: [warning] 49-49:
Variable name must be in mixedCase
contracts/base/GeneralMiddleware.sol: [warning] 67-67:
Named parameters missing. MIN unnamed argumenst is 4
contracts/base/GeneralMiddleware.sol: [warning] 78-78:
Named parameters missing. MIN unnamed argumenst is 4
contracts/base/GeneralMiddleware.sol: [warning] 81-81:
All public or external methods in a contract must override a definition from an interface
contracts/base/GeneralMiddleware.sol: [warning] 97-97:
Named parameters missing. MIN unnamed argumenst is 4
contracts/base/GeneralMiddleware.sol: [warning] 126-126:
Named parameters missing. MIN unnamed argumenst is 4
contracts/base/GeneralMiddleware.sol: [warning] 143-143:
Named parameters missing. MIN unnamed argumenst is 4
contracts/base/GeneralMiddleware.sol: [warning] 156-156:
Named parameters missing. MIN unnamed argumenst is 4
contracts/base/GeneralMiddleware.sol: [warning] 176-176:
Code contains empty blocks
Additional comments not posted (3)
contracts/base/GeneralMiddleware.sol (3)
1-1: Updated SPDX license identifier to Apache-2.0.
3-17: Copyright and licensing information added.
Line range hint
81-81: Ensure that all public or external methods override a definition from an interface.
RnkSngh
force-pushed
the
raunak/spdx-licence
branch
2 times, most recently
from
1ab69ea to
4c25c9e
Compare
RnkSngh
force-pushed
the
raunak/spdx-licence
branch
from
4c25c9e to
3b901ab
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (4)
contracts/base/GeneralMiddleware.sol (4)
Line range hint
21-21: Remove the unused import to clean up the code.- import {Ibc, UniversalPacket, AckPacket} from "../libs/Ibc.sol"; + import {UniversalPacket, AckPacket} from "../libs/Ibc.sol";
Line range hint
48-48: Consider renamingMW_IDtomwIdto adhere to Solidity naming conventions.- uint256 public MW_ID; + uint256 public mwId;
Line range hint
66-66: Consider using named parameters for clarity and maintainability.- function onRecvMWPacket( + function onRecvMWPacket( + bytes32 channelId, + UniversalPacket calldata ucPacket, + uint256 mwIndex, + address[] calldata mwAddrs + ) external onlyIbcMw returns (AckPacket memory ackPacket) {
Line range hint
175-175: Avoid leaving function bodies empty. Implement or explicitly comment on why they are empty.- function onRecvUniversalPacket(bytes32 channelId, UniversalPacket calldata ucPacket) + function onRecvUniversalPacket(bytes32 channelId, UniversalPacket calldata ucPacket) { + // TODO: Implement or provide rationale for empty function + }
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (25)
- LICENSE (1 hunks)
- contracts/base/GeneralMiddleware.sol (1 hunks)
- contracts/core/Dispatcher.sol (1 hunks)
- contracts/core/OptimisticLightClient.sol (1 hunks)
- contracts/core/OptimisticProofVerifier.sol (1 hunks)
- contracts/core/UniversalChannelHandler.sol (1 hunks)
- contracts/examples/Earth.sol (1 hunks)
- contracts/examples/Mars.sol (1 hunks)
- contracts/interfaces/IDispatcher.sol (1 hunks)
- contracts/interfaces/ILightClient.sol (1 hunks)
- contracts/interfaces/IProofVerifier.sol (1 hunks)
- contracts/interfaces/IUniversalChannelHandler.sol (1 hunks)
- contracts/interfaces/IbcDispatcher.sol (1 hunks)
- contracts/interfaces/IbcMiddleware.sol (1 hunks)
- contracts/interfaces/IbcReceiver.sol (1 hunks)
- contracts/interfaces/IbcReceiverUpgradeable.sol (1 hunks)
- contracts/libs/Ibc.sol (1 hunks)
- contracts/libs/IbcErrors.sol (1 hunks)
- contracts/libs/IbcUtils.sol (1 hunks)
- contracts/utils/DummyLightClient.sol (1 hunks)
- contracts/utils/DummyProofVerifier.sol (1 hunks)
- contracts/utils/GasAudit.sol (1 hunks)
- test/upgradeableProxy/upgrades/DispatcherV2.sol (1 hunks)
- test/upgradeableProxy/upgrades/DispatcherV2Initializable.sol (1 hunks)
- test/utils/TestUtils.t.sol (1 hunks)
Files skipped from review as they are similar to previous changes (24)
- LICENSE
- contracts/core/Dispatcher.sol
- contracts/core/OptimisticLightClient.sol
- contracts/core/OptimisticProofVerifier.sol
- contracts/core/UniversalChannelHandler.sol
- contracts/examples/Earth.sol
- contracts/examples/Mars.sol
- contracts/interfaces/IDispatcher.sol
- contracts/interfaces/ILightClient.sol
- contracts/interfaces/IProofVerifier.sol
- contracts/interfaces/IUniversalChannelHandler.sol
- contracts/interfaces/IbcDispatcher.sol
- contracts/interfaces/IbcMiddleware.sol
- contracts/interfaces/IbcReceiver.sol
- contracts/interfaces/IbcReceiverUpgradeable.sol
- contracts/libs/Ibc.sol
- contracts/libs/IbcErrors.sol
- contracts/libs/IbcUtils.sol
- contracts/utils/DummyLightClient.sol
- contracts/utils/DummyProofVerifier.sol
- contracts/utils/GasAudit.sol
- test/upgradeableProxy/upgrades/DispatcherV2.sol
- test/upgradeableProxy/upgrades/DispatcherV2Initializable.sol
- test/utils/TestUtils.t.sol
Additional Context Used
GitHub Check Runs (1)
lint success (11)
contracts/base/GeneralMiddleware.sol: [warning] 21-21:
imported name Ibc is not used
contracts/base/GeneralMiddleware.sol: [warning] 48-48:
Variable name must be in mixedCase
contracts/base/GeneralMiddleware.sol: [warning] 66-66:
Named parameters missing. MIN unnamed argumenst is 4
contracts/base/GeneralMiddleware.sol: [warning] 77-77:
Named parameters missing. MIN unnamed argumenst is 4
contracts/base/GeneralMiddleware.sol: [warning] 80-80:
All public or external methods in a contract must override a definition from an interface
contracts/base/GeneralMiddleware.sol: [warning] 96-96:
Named parameters missing. MIN unnamed argumenst is 4
contracts/base/GeneralMiddleware.sol: [warning] 125-125:
Named parameters missing. MIN unnamed argumenst is 4
contracts/base/GeneralMiddleware.sol: [warning] 142-142:
Named parameters missing. MIN unnamed argumenst is 4
contracts/base/GeneralMiddleware.sol: [warning] 155-155:
Named parameters missing. MIN unnamed argumenst is 4
contracts/base/GeneralMiddleware.sol: [warning] 175-175:
Code contains empty blocks
Additional comments not posted (2)
contracts/base/GeneralMiddleware.sol (2)
1-1: Updated SPDX license identifier to Apache-2.0.
3-17: Copyright and licensing information is correctly updated and well-documented.
PR to add licencing info to add an Apache 2.0 licence to this repo.
Summary by CodeRabbit
Documentation
Refactor
New Features