update close channel api to be future compatible · open-ibc/vibc-core-smart-contracts@bf6114e

Triggered via pull request April 17, 2024 17:26

RnkSngh

synchronize #88

raunak/uch-ch-close-api

Status Success

Total duration 1m 9s

Artifacts –

lint.yml

on: pull_request

11 warnings

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

lint: contracts/base/GeneralMiddleware.sol#L5

imported name Ibc is not used

lint: contracts/base/GeneralMiddleware.sol#L25

Variable name must be in mixedCase

lint: contracts/base/GeneralMiddleware.sol#L43

Named parameters missing. MIN unnamed argumenst is 4

lint: contracts/base/GeneralMiddleware.sol#L54

Named parameters missing. MIN unnamed argumenst is 4

lint: contracts/base/GeneralMiddleware.sol#L57

All public or external methods in a contract must override a definition from an interface

lint: contracts/base/GeneralMiddleware.sol#L73

Named parameters missing. MIN unnamed argumenst is 4