-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve description of PSF axes #175
base: master
Are you sure you want to change the base?
Conversation
Proposal to clarify the meaning of the axes in the PSF histograms (see also issue open-gamma-ray-astro#174)
@@ -18,9 +18,9 @@ Columns: | |||
* ``ENERG_LO``, ``ENERG_HI`` -- ndim: 1, unit: TeV | |||
* True energy axis | |||
* ``THETA_LO``, ``THETA_HI`` -- ndim: 1, unit: deg | |||
* Field of view offset axis (see :ref:`coords-fov`) | |||
* Angular distance to centre of the array pointing direction (see :ref:`coords-fov`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AE vs BE? Do we have a guideline for that? I would say AE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep "axis", as this refers to the axis definition of the matrix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not say "Array", as this may be used by non-IACT instruments...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But then some one should change https://gamma-astro-data-formats.readthedocs.io/en/latest/general/coordinates.html#coords-fov , as here it is explicitly said that these types of coordinates are used for IACTs and that the centre of the FOV is the centre of the array pointing direction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TarekHC I would also say that the issue of rewording everything so it also works e.g. for HAWC is a larger one and should probably be done by someone from the Water Cherenkov community.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are too many places where this is currently an issue.
* ``RAD_LO``, ``RAD_HI`` -- ndim: 1, unit: deg | ||
* Offset angle from source position | ||
* Angular distance between simulated and reconstructed direction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add axis here to be consistent.
Change from BE to AE; added zxis
It's also not mentioned that these columns are lower and upper bin edges respectively. Maybe we should write it like this?
|
Proposal to clarify the meaning of the axes in the PSF histograms (see also issue #174)