✨ [#4991] Add selection of Referentielijsten services to general config #4992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sergei-maertens not sure either, I might have to rebase? |
Comment on lines
562
to
571
| referentielijsten_services = models.ManyToManyField( | ||
| Service, | ||
| verbose_name=_("referentielijsten services"), | ||
| help_text=_( | ||
| "List of services that are instances of the Referentielijsten API. " | ||
| "The selected services will be shown as options when configuring " | ||
| "select or selectboxes components to be populated from Referentielijsten." | ||
| ), | ||
| ) |
There was a problem hiding this comment.
The test failures seem to be from the admin tests for global configuration - perhaps it's because this field is not marked as blank=True which makes it required now, while it shouldn't be?
the selected services will be shown as options when configuring select/selectboxes using Referentielijsten
stevenbal
force-pushed
the
feature/4991-referentielijsten-config
branch
from
01c422b to
b62f6a8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4992 +/- ##
=======================================
Coverage 96.66% 96.66%
=======================================
Files 761 761
Lines 25959 25962 +3
Branches 3394 3394
=======================================
+ Hits 25093 25096 +3
Misses 601 601
Partials 265 265 ☔ View full report in Codecov by Sentry. |
sergei-maertens
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4991
Changes
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shDockerfile/scripts
./binfolderCommit hygiene