Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid empty variables being marked as geometry fields (objects API registration) #4988

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

sergei-maertens
Copy link
Member

Closes #4978 (partially)

Changes

Variables with empty keys are not usable so these are now excluded from the isGeometry checks.

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

The empty string as key for a variable incorrectly marked a variable
as geometry variable because the empty values match. Now we only
consider non-empty values as valid, as a variable *must* have a
non-empty key to be valid and mappable.
@sergei-maertens sergei-maertens requested a review from vaszig January 6, 2025 14:56
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.66%. Comparing base (7f8fd3b) to head (0c3da88).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4988      +/-   ##
==========================================
- Coverage   96.66%   96.66%   -0.01%     
==========================================
  Files         761      761              
  Lines       25957    25957              
  Branches     3393     3393              
==========================================
- Hits        25092    25091       -1     
  Misses        601      601              
- Partials      264      265       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens merged commit a425cc6 into master Jan 6, 2025
33 checks passed
@sergei-maertens sergei-maertens deleted the issue/4978-empty-variable-marked-as-geo branch January 6, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open Forms 3.0 test plan
2 participants