🐛 [#4579] Ensure triggerFromStep uses the correct current_step

[stevenbal]

previously the current step was inferred by looking at the last completed step and considering the step after that the current step. This does not work however if you complete a step and go back to the previous step, so instead we explicitly pass the current form step via the serializer context

Closes #4579

Changes

• Ensure triggerFromStep uses the correct current_step

Checklist

Check off the items that are completed or not relevant.

• Impact on features

  • Checked copying a form
  • Checked import/export of a form
  • Config checks in the configuration overview admin page
  • Problem detection in the admin email digest is handled

• Release management

  • I have labelled the PR as "needs-backport" accordingly

• I have updated the translations assets (you do NOT need to provide translations)

  • Ran ./bin/makemessages_js.sh
  • Ran ./bin/compilemessages_js.sh

• Dockerfile/scripts

  • Updated the Dockerfile with the necessary scripts from the ./bin folder

• Commit hygiene

  • Commit messages refer to the relevant Github issue
  • Commit messages explain the "why" of change, not the how

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.62%. Comparing base (b0b5055) to head (e7c4ef3).
Report is 7 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4967   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files         760      760           
  Lines       25838    25838           
  Branches     3386     3386           
=======================================
  Hits        24965    24965           
  Misses        608      608           
  Partials      265      265           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stevenbal]

I was surprised (and suspicious) about this fix, is there a reason why previously the current_step was inferred for this flow, instead of explicitly passed to get_rules_to_evaluate?

[sergei-maertens]

this function exists because the logic for the submission as a whole still needs to be evaluated during registration/processing after it's completed. In those contexts, there isn't a submission step, and it's also not relevant for the "trigger_from_step", because the assumption is that this only gets called for completed submissions that have gone through all the steps anyway.

Clearly this was a wrong assumption - as this does get called in the logic check serialization too which is in the context of a particular step. Nice find!

[sergei-maertens]

Backports:

• 2.8.x: 0ad3170
• 2.7.x: 05f143e