-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#4825] Log prefill retrieve empty only for the used authentication flow #4959
[#4825] Log prefill retrieve empty only for the used authentication flow #4959
Conversation
This is a quick fix but I would like your opinion on this before I try to write some tests. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4959 +/- ##
=======================================
Coverage 96.62% 96.62%
=======================================
Files 760 760
Lines 25837 25838 +1
Branches 3385 3386 +1
=======================================
+ Hits 24964 24965 +1
Misses 608 608
Partials 265 265 ☔ View full report in Codecov by Sentry. |
4f3a53f
to
e900c0b
Compare
This is a fix which is meant for backporting. The 'proper' fix will be implemented in a different PR, out of the scope of the v3.0.
e900c0b
to
592f1f3
Compare
@sergei-maertens I have a difficulty backporting this because we did the refactor in v3.0 and just cherry-picking the commit will not work (the |
This is a fix which is meant for backporting. The 'proper' fix will be implemented in a different PR, out of the scope of the v3.0. Backport-of: #4959
This is a fix which is meant for backporting. The 'proper' fix will be implemented in a different PR, out of the scope of the v3.0. Backport-of: #4959
This is created in order to fix the stable branch and has to do with the backport-of: #4959
This is created in order to fix the stable branch and has to do with the backport-of: #4959
Closes #4825
Changes
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Dockerfile/scripts
./bin
folderCommit hygiene