Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4825] Log prefill retrieve empty only for the used authentication flow #4959

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Dec 19, 2024

Closes #4825

Changes

  • Updated logging to only log empty data for the authentication flow that is used in the submission.

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@vaszig
Copy link
Contributor Author

vaszig commented Dec 19, 2024

This is a quick fix but I would like your opinion on this before I try to write some tests.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.62%. Comparing base (260a985) to head (592f1f3).
Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4959   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files         760      760           
  Lines       25837    25838    +1     
  Branches     3385     3386    +1     
=======================================
+ Hits        24964    24965    +1     
  Misses        608      608           
  Partials      265      265           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaszig vaszig marked this pull request as draft December 19, 2024 15:04
@vaszig vaszig added the needs-backport Fix must be backported to stable release branch label Dec 20, 2024
@vaszig vaszig force-pushed the fix/4825-digest-reports-prefill-failures-when-multiple-auth-flows branch from 4f3a53f to e900c0b Compare December 20, 2024 10:52
@vaszig vaszig marked this pull request as ready for review December 20, 2024 10:53
This is a fix which is meant for backporting. The 'proper' fix will be
implemented in a different PR, out of the scope of the v3.0.
@vaszig vaszig force-pushed the fix/4825-digest-reports-prefill-failures-when-multiple-auth-flows branch from e900c0b to 592f1f3 Compare December 20, 2024 12:40
@vaszig vaszig merged commit b0b5055 into master Dec 23, 2024
33 checks passed
@vaszig vaszig deleted the fix/4825-digest-reports-prefill-failures-when-multiple-auth-flows branch December 23, 2024 09:04
@vaszig
Copy link
Contributor Author

vaszig commented Dec 23, 2024

@sergei-maertens I have a difficulty backporting this because we did the refactor in v3.0 and just cherry-picking the commit will not work (the sources.py is a new file in 3.0).

vaszig added a commit that referenced this pull request Dec 23, 2024
This is a fix which is meant for backporting. The 'proper' fix will be
implemented in a different PR, out of the scope of the v3.0.

Backport-of: #4959
vaszig added a commit that referenced this pull request Dec 23, 2024
This is a fix which is meant for backporting. The 'proper' fix will be
implemented in a different PR, out of the scope of the v3.0.

Backport-of: #4959
@vaszig
Copy link
Contributor Author

vaszig commented Dec 23, 2024

Backports:

vaszig added a commit that referenced this pull request Dec 24, 2024
This is created in order to fix the stable branch and has to do with the
backport-of: #4959
@vaszig vaszig mentioned this pull request Dec 24, 2024
10 tasks
vaszig added a commit that referenced this pull request Dec 24, 2024
This is created in order to fix the stable branch and has to do with the
backport-of: #4959
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport Fix must be backported to stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daily digest reporting prefill failures for forms that work with more then 1 auth "flow"
2 participants