Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objects-api and zgw apis geometry coordinates data order #4957

Merged

Conversation

robinmolen
Copy link
Contributor

Closes #4955

Changes

Changes the order of the geometry coordinates data from [lat, lng] to [lng, lat].

The coordinates that we receive from the map component are in [lat, lng] order. This same order was used when passing the coordinates to the Objects-api and zgw apis backends, but these expect the geometry data to adhere the geoJson geometry data (i.e. the coordinates in [lng, lat] order)

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

…at format

The Objects-api and zgw-apis backend registrations expect the geometry coordinates data to follow the lng/lat format.

Our coordinates are saved as [lat,lng], so for these registrations we have to switch the coordinates around
@robinmolen robinmolen added the needs-backport Fix must be backported to stable release branch label Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.61%. Comparing base (eedffb3) to head (fbfc62f).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4957   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files         760      760           
  Lines       25820    25825    +5     
  Branches     3383     3384    +1     
=======================================
+ Hits        24947    24952    +5     
  Misses        608      608           
  Partials      265      265           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with support - the impression that nobody uses this component + registration backend combination yet, and if wrong data would have been entering the system, they would've noticed by now.

@sergei-maertens sergei-maertens merged commit 082325c into master Dec 19, 2024
34 checks passed
@sergei-maertens sergei-maertens deleted the bug/4955-registration-backend-geometry-data-format branch December 19, 2024 12:10
sergei-maertens pushed a commit that referenced this pull request Dec 19, 2024
…at format

The Objects-api and zgw-apis backend registrations expect the geometry coordinates data to follow the lng/lat format.

Our coordinates are saved as [lat,lng], so for these registrations we have to switch the coordinates around

Backport-of: #4957
sergei-maertens pushed a commit that referenced this pull request Dec 19, 2024
…at format

The Objects-api and zgw-apis backend registrations expect the geometry coordinates data to follow the lng/lat format.

Our coordinates are saved as [lat,lng], so for these registrations we have to switch the coordinates around

Backport-of: #4957
@sergei-maertens
Copy link
Member

Backports:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport Fix must be backported to stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Objects api and zgw apis geometry coordinates using wrong order
2 participants