-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Objects-api and zgw apis geometry coordinates data order #4957
Objects-api and zgw apis geometry coordinates data order #4957
Conversation
…at format The Objects-api and zgw-apis backend registrations expect the geometry coordinates data to follow the lng/lat format. Our coordinates are saved as [lat,lng], so for these registrations we have to switch the coordinates around
… coordinates ordering
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4957 +/- ##
=======================================
Coverage 96.61% 96.61%
=======================================
Files 760 760
Lines 25820 25825 +5
Branches 3383 3384 +1
=======================================
+ Hits 24947 24952 +5
Misses 608 608
Partials 265 265 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked with support - the impression that nobody uses this component + registration backend combination yet, and if wrong data would have been entering the system, they would've noticed by now.
…at format The Objects-api and zgw-apis backend registrations expect the geometry coordinates data to follow the lng/lat format. Our coordinates are saved as [lat,lng], so for these registrations we have to switch the coordinates around Backport-of: #4957
…at format The Objects-api and zgw-apis backend registrations expect the geometry coordinates data to follow the lng/lat format. Our coordinates are saved as [lat,lng], so for these registrations we have to switch the coordinates around Backport-of: #4957
Closes #4955
Changes
Changes the order of the geometry coordinates data from
[lat, lng]
to[lng, lat]
.The coordinates that we receive from the map component are in [lat, lng] order. This same order was used when passing the coordinates to the Objects-api and zgw apis backends, but these expect the geometry data to adhere the geoJson geometry data (i.e. the coordinates in [lng, lat] order)
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Dockerfile/scripts
./bin
folderCommit hygiene