-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#4821] Fixed email digest for BRK and addressNL component #4952
[#4821] Fixed email digest for BRK and addressNL component #4952
Conversation
6fbff18
to
01ead5c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4952 +/- ##
=======================================
Coverage 96.61% 96.61%
=======================================
Files 760 760
Lines 25817 25825 +8
Branches 3382 3384 +2
=======================================
+ Hits 24944 24952 +8
Misses 608 608
Partials 265 265 ☔ View full report in Codecov by Sentry. |
We want the email digest to report problems (broken configuration) for the addressNL component only when a valid BRK service and the validator are defined/configured.
01ead5c
to
28702dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's backport this too 🤔
We want the email digest to report problems (broken configuration) for the addressNL component only when a valid BRK service and the validator are defined/configured. Backport-of: #4952
We want the email digest to report problems (broken configuration) for the addressNL component only when a valid BRK service and the validator are defined/configured. Backport-of: #4952
Closes #4821
Changes
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Dockerfile/scripts
./bin
folderCommit hygiene