Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4821] Fixed email digest for BRK and addressNL component #4952

Merged

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Dec 18, 2024

Closes #4821

Changes

  • We want the email digest to report problems (broken configuration) for the addressNL component only when a valid BRK service and the validator are defined/configured.

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

src/openforms/contrib/brk/service.py Outdated Show resolved Hide resolved
src/openforms/contrib/brk/tests/base.py Outdated Show resolved Hide resolved
@vaszig vaszig force-pushed the fix/4821-do-not-report-brk-addressnl-problems-if-not-configured branch from 6fbff18 to 01ead5c Compare December 18, 2024 13:47
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.61%. Comparing base (738be59) to head (28702dd).
Report is 20 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4952   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files         760      760           
  Lines       25817    25825    +8     
  Branches     3382     3384    +2     
=======================================
+ Hits        24944    24952    +8     
  Misses        608      608           
  Partials      265      265           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

We want the email digest to report problems (broken configuration) for
the addressNL component only when a valid BRK service and the validator
are defined/configured.
@vaszig vaszig force-pushed the fix/4821-do-not-report-brk-addressnl-problems-if-not-configured branch from 01ead5c to 28702dd Compare December 19, 2024 09:38
Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's backport this too 🤔

@sergei-maertens sergei-maertens added the needs-backport Fix must be backported to stable release branch label Dec 19, 2024
@vaszig vaszig merged commit e11c687 into master Dec 19, 2024
33 checks passed
@vaszig vaszig deleted the fix/4821-do-not-report-brk-addressnl-problems-if-not-configured branch December 19, 2024 10:19
vaszig added a commit that referenced this pull request Dec 19, 2024
We want the email digest to report problems (broken configuration) for
the addressNL component only when a valid BRK service and the validator
are defined/configured.

Backport-of: #4952
vaszig added a commit that referenced this pull request Dec 19, 2024
We want the email digest to report problems (broken configuration) for
the addressNL component only when a valid BRK service and the validator
are defined/configured.

Backport-of: #4952
@vaszig
Copy link
Contributor Author

vaszig commented Dec 19, 2024

Backports:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport Fix must be backported to stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daily digest always reports BRK issues, for all users/environements regardless of configuration.
2 participants