Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom TITLE and COM parameters in Ogone payment plugin #4932

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

sergei-maertens
Copy link
Member

@sergei-maertens sergei-maertens commented Dec 16, 2024

Closes #3457

Changes

  • Added support for TITLE and COM parameter templates
  • Exposed config options in the frontend

Tested this end-to-end with our Ogone test account and works as expected - the custom description is evaluated and displayed in the transaction history.

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.59%. Comparing base (fd2a376) to head (0343550).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4932   +/-   ##
=======================================
  Coverage   96.59%   96.59%           
=======================================
  Files         758      758           
  Lines       25774    25787   +13     
  Branches     3379     3379           
=======================================
+ Hits        24897    24910   +13     
  Misses        612      612           
  Partials      265      265           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens force-pushed the feature/3457-ogone-custom-title-and-com branch from db10b29 to 1cae4c7 Compare December 17, 2024 08:43
The COM parameter is sent/displayed in the payment receipts of the
merchant and can contain references for the organization's
administration.

The TITLE is (supposedly) displayed on the payment page, however this
seems not to be functioning with the simulator.

If no custom templates are specified, we use the legacy behaviour and
include a hardcoded description.
Added the com template and title template configuration fields to
the configuration options modal.
@sergei-maertens sergei-maertens force-pushed the feature/3457-ogone-custom-title-and-com branch from 1cae4c7 to 0343550 Compare December 17, 2024 11:01
@sergei-maertens sergei-maertens merged commit ac7be79 into master Dec 17, 2024
15 of 16 checks passed
@sergei-maertens sergei-maertens deleted the feature/3457-ogone-custom-title-and-com branch December 17, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting custom Ogone "Title" and "Com"
2 participants