Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4853] Fix non required fields in registration backends serializers #4924

Merged

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Dec 16, 2024

Closes #4853

Changes

  • Updated serializers with non required fields. When we send empty strings to the backend we need allow_blank=True

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@vaszig vaszig added the needs-backport Fix must be backported to stable release branch label Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.58%. Comparing base (753691c) to head (2b3967c).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4924   +/-   ##
=======================================
  Coverage   96.58%   96.58%           
=======================================
  Files         757      757           
  Lines       25783    25783           
  Branches     3390     3390           
=======================================
  Hits        24902    24902           
  Misses        616      616           
  Partials      265      265           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens merged commit 3d6ffab into master Dec 16, 2024
33 checks passed
@sergei-maertens sergei-maertens deleted the fix/4853-cannot-empty-non-required-registration-fields branch December 16, 2024 17:01
@sergei-maertens
Copy link
Member

Backports:

Not backporting to older versions, since the UI/UX rework was started in 2.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport Fix must be backported to stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot empty registration fields
2 participants