Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💥 Remove OR-filter behaviour on form definitions endpoint #4913

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

sergei-maertens
Copy link
Member

Part of #3283

Providing both the used_in and is_reusable filter parameters no longer returns records that match either condition, instead it applies the default AND behaviour.

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Providing both the used_in and is_reusable filter parameters no longer
returns records that match either condition, instead it applies the
default AND behaviour.
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.58%. Comparing base (3a70208) to head (aa7abce).
Report is 14 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4913   +/-   ##
=======================================
  Coverage   96.57%   96.58%           
=======================================
  Files         757      757           
  Lines       25750    25728   -22     
  Branches     3383     3378    -5     
=======================================
- Hits        24869    24849   -20     
+ Misses        616      615    -1     
+ Partials      265      264    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens changed the title Remove OR-filter behaviour on form definitions endpoint 💥 Remove OR-filter behaviour on form definitions endpoint Dec 13, 2024
@sergei-maertens sergei-maertens merged commit 9970b35 into master Dec 17, 2024
33 checks passed
@sergei-maertens sergei-maertens deleted the cleanup/3283-remove-fd-or-filtering branch December 17, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants