-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#4321] Allow max number of submissions per form #4885
[#4321] Allow max number of submissions per form #4885
Conversation
c23efc9
to
0bda3f3
Compare
a7718b3
to
cbf9ee9
Compare
cbf9ee9
to
d9d0005
Compare
d9d0005
to
77c5a24
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4885 +/- ##
=======================================
Coverage 96.57% 96.58%
=======================================
Files 757 757
Lines 25728 25783 +55
Branches 3379 3390 +11
=======================================
+ Hits 24847 24902 +55
Misses 616 616
Partials 265 265 ☔ View full report in Codecov by Sentry. |
77c5a24
to
e7e6d5a
Compare
e7e6d5a
to
4081f20
Compare
src/openforms/js/components/admin/form_design/SubmissionFields.js
Outdated
Show resolved
Hide resolved
9270ede
to
f1815ad
Compare
@@ -485,6 +517,7 @@ def copy(self): | |||
) | |||
copy.slug = _("{slug}-copy").format(slug=self.slug) | |||
copy.product = self.product | |||
copy.submission_counter = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes :)
src/openforms/js/components/admin/form_design/SubmissionFields.js
Outdated
Show resolved
Hide resolved
f1815ad
to
ea488a3
Compare
I do not know why test coverage doesn't like the |
ea488a3
to
a21cc64
Compare
Closes #4321 partly
Changes
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Commit hygiene