Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4762] Add cosign data (bsn) to the stuf-zds creerzaak bericht #4835

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Nov 19, 2024

Closes #4762

Changes

  • Added the cosigner's bsn to the creerzaak bericht

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.58%. Comparing base (796bb43) to head (f502fef).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4835   +/-   ##
=======================================
  Coverage   96.58%   96.58%           
=======================================
  Files         748      748           
  Lines       25476    25477    +1     
  Branches     3368     3368           
=======================================
+ Hits        24605    24606    +1     
  Misses        608      608           
  Partials      263      263           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@vaszig vaszig requested a review from stevenbal November 19, 2024 11:46
@vaszig vaszig force-pushed the task/4762-include-cosign-data-in-stuf-zds branch from e53d9b9 to f502fef Compare November 19, 2024 13:04
@sergei-maertens sergei-maertens merged commit 77e2cd6 into master Nov 19, 2024
32 of 33 checks passed
@sergei-maertens sergei-maertens deleted the task/4762-include-cosign-data-in-stuf-zds branch November 19, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Co-sign data is not included in stuf-zds creeerzaak bericht
2 participants