Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/open producten price #4790

Conversation

Floris272
Copy link

@Floris272 Floris272 commented Oct 24, 2024

Closes #...

Changes

  • Management command to import product types and their current price options from Open Producten (PoC)
  • Celery task that calls the command.
  • ProductPrice form component that will be replaced by a radio component to show the price option based on the product set on the form.

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@Floris272 Floris272 self-assigned this Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 97.19626% with 6 lines in your changes missing coverage. Please review.

Project coverage is 96.56%. Comparing base (4486396) to head (709a1d6).
Report is 84 commits behind head on master.

Files with missing lines Patch % Lines
src/openforms/contrib/open_producten/tasks.py 58.33% 5 Missing ⚠️
...c/openforms/contrib/open_producten/price_import.py 97.05% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #4790    +/-   ##
========================================
  Coverage   96.55%   96.56%            
========================================
  Files         748      756     +8     
  Lines       25399    25611   +212     
  Branches     3354     3387    +33     
========================================
+ Hits        24525    24731   +206     
- Misses        609      614     +5     
- Partials      265      266     +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Floris272 Floris272 force-pushed the feature/open-producten-price branch from f54d6a3 to e00a923 Compare October 24, 2024 13:10
@sergei-maertens
Copy link
Member

Didn't get to reviewing yet, I'll try to get it done on Monday!

@Floris272 Floris272 force-pushed the feature/open-producten-price branch from e00a923 to 709a1d6 Compare October 29, 2024 13:07
@joeribekker
Copy link
Contributor

Discussed in refinement: We definitely like the general setup of retrieving prices from the product API. Unfortunately, there is now also another product API (Roxit) which differs (ofcourse) and meanwhile we also introduced prices from variables in OF.

So, we really need to take a new approach on this. Closing the Pull Request since we're not merging as is but we will definitely do something similar. You did some valuable work here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants