-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/open producten price #4790
Feature/open producten price #4790
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4790 +/- ##
========================================
Coverage 96.55% 96.56%
========================================
Files 748 756 +8
Lines 25399 25611 +212
Branches 3354 3387 +33
========================================
+ Hits 24525 24731 +206
- Misses 609 614 +5
- Partials 265 266 +1 ☔ View full report in Codecov by Sentry. |
f54d6a3
to
e00a923
Compare
Didn't get to reviewing yet, I'll try to get it done on Monday! |
e00a923
to
709a1d6
Compare
Discussed in refinement: We definitely like the general setup of retrieving prices from the product API. Unfortunately, there is now also another product API (Roxit) which differs (ofcourse) and meanwhile we also introduced prices from variables in OF. So, we really need to take a new approach on this. Closing the Pull Request since we're not merging as is but we will definitely do something similar. You did some valuable work here! |
Closes #...
Changes
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Commit hygiene