Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/4720 accessibility improvements visibility navigation #4776

Conversation

robinmolen
Copy link
Contributor

Partially Closes #4720

Changes

  • The skiplink is now the first interactive element, and is shown when it has focus
  • New sdk translations
  • Changed the filename of the submission PDF report

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@robinmolen robinmolen marked this pull request as draft October 21, 2024 15:23
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.55%. Comparing base (2cfc111) to head (9d3b9ba).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4776   +/-   ##
=======================================
  Coverage   96.55%   96.55%           
=======================================
  Files         748      748           
  Lines       25399    25399           
  Branches     3354     3354           
=======================================
  Hits        24525    24525           
  Misses        609      609           
  Partials      265      265           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robinmolen robinmolen marked this pull request as ready for review October 22, 2024 09:13
@sergei-maertens sergei-maertens force-pushed the feature/4720-accessibility-improvements-visibility-navigation branch from aa824c3 to ae57a04 Compare October 28, 2024 11:49
Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait for the SDK PR to be merged and released so we get a proper CI check when this is merged.

@sergei-maertens sergei-maertens merged commit 7bae4ca into master Oct 28, 2024
34 checks passed
@sergei-maertens sergei-maertens deleted the feature/4720-accessibility-improvements-visibility-navigation branch October 28, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility improvements - Visibility and navigation
2 participants