Improve the user experience of the form variable select/dropdown #4730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4730 +/- ##
=======================================
Coverage 96.56% 96.56%
=======================================
Files 746 746
Lines 25191 25191
Branches 3313 3313
=======================================
Hits 24325 24325
Misses 602 602
Partials 264 264 ☔ View full report in Codecov by Sentry. |
sergei-maertens
commented
Oct 3, 2024
There was a problem hiding this comment.
@robinmolen I've cleaned up the commit history since it went a bit wrong in #4675 😬
src/openforms/js/components/admin/form_design/logic/actions/dmn/DMNActionConfig.stories.js
Outdated
Show resolved
Hide resolved
src/openforms/js/components/admin/form_design/logic/actions/dmn/DMNActionConfig.stories.js
Outdated
Show resolved
Hide resolved
src/openforms/js/components/admin/form_design/variables/constants.js
Outdated
Show resolved
Hide resolved
9 tasks
robinmolen
force-pushed
the
feature/4524-react-select-in-variable-dropdown-cleaned-up
branch
from
c611cef to
1b1d542
Compare
sergei-maertens
force-pushed
the
feature/4524-react-select-in-variable-dropdown-cleaned-up
branch
from
5aa0e67 to
7fc696a
Compare
sergei-maertens
changed the title
sergei-maertens
force-pushed
the
feature/4524-react-select-in-variable-dropdown-cleaned-up
branch
3 times, most recently
from
489f3c1 to
3937b7e
Compare
sergei-maertens
commented
Oct 11, 2024
There was a problem hiding this comment.
@robinmolen I did some final polishing so we can finally wrap up this feature :)
Marked SelectWithoutFormik as deprecated
Added sources and formDefinitions. This allows for the testing of the new VariableSelection react-select grouping + fixed the stories broken by the switch to react-select
sergei-maertens
force-pushed
the
feature/4524-react-select-in-variable-dropdown-cleaned-up
branch
from
3937b7e to
cf881a6
Compare
* Ensure the variabels editor tabs and groups in variable dropdown use the same literals for component/user defined/static variables * Switched markup/styling to CSS grid for better visual appearance when labels wrap * Added stories for visual edge cases so that we have visual regression testing * Re-organized the React component code a bit to avoid defining inline components
Attempted to make the code a bit easier/simpler, and clean up the test helpers to use accessible queries.
sergei-maertens
force-pushed
the
feature/4524-react-select-in-variable-dropdown-cleaned-up
branch
from
cf881a6 to
72859d8
Compare
sergei-maertens
deleted the
feature/4524-react-select-in-variable-dropdown-cleaned-up
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4524
Closes #4675
I've cleaned up the commit history from the original PR
Changes
The variable dropdown now uses the react-select component. Allowing for searching within the options
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shCommit hygiene