-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/4686 email and StUF-ZDS inline form #4708
Closed
robinmolen
wants to merge
13
commits into
master
from
feature/4686-email-and-StUF-inline-form-UX-updates
Closed
Feature/4686 email and StUF-ZDS inline form #4708
robinmolen
wants to merge
13
commits into
master
from
feature/4686-email-and-StUF-inline-form-UX-updates
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinmolen
force-pushed
the
feature/4686-email-and-StUF-inline-form-UX-updates
branch
2 times, most recently
from
September 25, 2024 09:06
abcd8bc
to
f3292dd
Compare
robinmolen
force-pushed
the
feature/4686-email-and-StUF-inline-form-UX-updates
branch
from
September 25, 2024 09:10
f3292dd
to
209eb3c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4708 +/- ##
==========================================
- Coverage 96.61% 96.56% -0.05%
==========================================
Files 746 746
Lines 25144 25174 +30
Branches 3302 3310 +8
==========================================
+ Hits 24292 24309 +17
- Misses 589 601 +12
- Partials 263 264 +1 ☔ View full report in Codecov by Sentry. |
…yling issue/4711-form-row-styling
…ne-form-UX-updates' into feature/4686-email-and-StUF-inline-form-UX-updates
Closed PR in favor of #4742 |
sergei-maertens
deleted the
feature/4686-email-and-StUF-inline-form-UX-updates
branch
October 26, 2024 19:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4686
Changes
The registration forms for Email and StUF-ZDS now use React components, instead of react-json-schema-form generated forms. This allows us to share styling and keep the styling uniform across forms. These changes also improve the user experience, by providing a simular form layout/logic as the other registration inline forms.
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Commit hygiene