🐛 [#4435] Fix infinite redirect on sessionrefresh for OIDC

[stevenbal]

Closes #4435

Changes

• Fix OIDC SessionRefresh middleware

Checklist

Check off the items that are completed or not relevant.

• Impact on features

  • Checked copying a form
  • Checked import/export of a form
  • Config checks in the configuration overview admin page
  • Problem detection in the admin email digest is handled

• Release management

  • I have labelled the PR as "needs-backport" accordingly

• I have updated the translations assets (you do NOT need to provide translations)

  • Ran ./bin/makemessages_js.sh
  • Ran ./bin/compilemessages_js.sh

• Commit hygiene

  • Commit messages refer to the relevant Github issue
  • Commit messages explain the "why" of change, not the how

[stevenbal]

@sergei-maertens since it's quite a few URLs that should be added to the exempt URLs, should I maybe add a migration or management command to do this (if the respective feature flags are set to true)?

[sergei-maertens]

@sergei-maertens since it's quite a few URLs that should be added to the exempt URLs, should I maybe add a migration or management command to do this (if the respective feature flags are set to true)?

can't we instead rename the field on the config to have an underscore and implement a property we can override at runtime throught the proxy models? All of this seems like something that can be automatically inferred from settings and I would rather not burden administrators with this.

This also makes removing the deprecated code/shims easier in 3.0 as we only need to delete code and we're done, without leaving stale data in the configuration that we cannot possibly explain to users to clean up.

IMO that sounds like the simpler solution.

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.57%. Comparing base (e64ea6a) to head (3cc8cba).
Report is 571 commits behind head on master.

Files with missing lines	Patch %	Lines
src/openforms/conf/base.py	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4438      +/-   ##
==========================================
- Coverage   96.58%   96.57%   -0.01%     
==========================================
  Files         720      720              
  Lines       24012    24002      -10     
  Branches     2845     2844       -1     
==========================================
- Hits        23191    23180      -11     
  Misses        559      559              
- Partials      262      263       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.