DMN configuration improvements #4282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4282 +/- ##
=======================================
Coverage 96.12% 96.12%
=======================================
Files 730 730
Lines 23502 23502
Branches 2757 2757
=======================================
Hits 22591 22591
Misses 645 645
Partials 266 266 ☔ View full report in Codecov by Sentry. |
sergei-maertens
changed the title
sergei-maertens
force-pushed
the
feature/4269-dmn-improvements
branch
from
1a926be to
0306362
Compare
sergei-maertens
added
the
needs-backport
sergei-maertens
force-pushed
the
feature/4269-dmn-improvements
branch
from
0306362 to
70e51dc
Compare
The input expressions require additional parsing to properly extract the required input variables for a decision table.
This should help form builders configure DMN tables to see which input expressions are expected by the decision engine.
Input expressions can be complex with the actual requested variable buried deep inside. We leverage the 'feelin' library to parse FEEL expressions so that we can extract the actual (likely) expected variables and combine this information with our retrieved input clauses. This result is used to build a list of DMN variables for input mapping - this list is ordered to put labeled literal variables at the top, followed by the extracted unlabeled variables, and finally the legal identifiers that are labeled but likely complex/edge cases. This implements the DMN 1.3 FEEL identifier specification to select candidates.
Use the existing VariableSelection component to render a dropdown of available Open Forms variables. Added an accessible label to the dropdowns in the mapping tables.
Updated the assertions for the existing stories so that the interaction tests pass again. Added a story for the complex expression cases.
This has the correct input dependency resolution implementation.
sergei-maertens
force-pushed
the
feature/4269-dmn-improvements
branch
from
70e51dc to
e8d591b
Compare
vaszig
approved these changes
May 10, 2024
|
|
||
| @include bem.element('mapping') { | ||
| display: flex; | ||
| flex-direction: column; |
There was a problem hiding this comment.
I see a difference in the display here between the storybook and the admin, is it only on my end?
There was a problem hiding this comment.
I noticed it too while developing - I think it may be because of some pages in the admin loading additional stylesheets (bootstrap) that aren't included in Storybook.
|
Backported to 2.6.x with 116214c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4269
Changes
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages.sh./bin/compilemessages_js.shCommit hygiene