Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4099] Fix crash when using legacy Objects API registration #4104

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Apr 3, 2024

Fixes #4099

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.10%. Comparing base (aa8cce3) to head (4360f45).
Report is 13 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4104   +/-   ##
=======================================
  Coverage   96.10%   96.10%           
=======================================
  Files         730      730           
  Lines       23089    23089           
  Branches     2698     2698           
=======================================
  Hits        22189    22189           
  Misses        638      638           
  Partials      262      262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens added the needs-backport Fix must be backported to stable release branch label Apr 3, 2024
Copy link
Contributor

@vaszig vaszig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the failing test has to do with flakiness?

@sergei-maertens sergei-maertens merged commit 3864870 into master Apr 4, 2024
22 of 23 checks passed
@sergei-maertens sergei-maertens deleted the issue/4099 branch April 4, 2024 09:48
@sergei-maertens
Copy link
Member

Backport to 2.6.x: 250c85c

sergei-maertens pushed a commit that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport Fix must be backported to stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding user variables can crash variables tab
3 participants