Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3725] Add problems to the email digest #4093

Merged
merged 5 commits into from
Apr 10, 2024

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Apr 2, 2024

Partly closes #3725

This PR handles only the first checkbox of the task, regarding the failed submissions.

@vaszig vaszig marked this pull request as draft April 2, 2024 14:42
@vaszig vaszig force-pushed the feature/3725-add-problems-to-email-digest branch from 04e78fd to 3077185 Compare April 3, 2024 14:57
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.13%. Comparing base (9b54457) to head (0eee5b5).
Report is 58 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4093      +/-   ##
==========================================
+ Coverage   96.09%   96.13%   +0.03%     
==========================================
  Files         730      731       +1     
  Lines       23076    23277     +201     
  Branches     2697     2718      +21     
==========================================
+ Hits        22176    22378     +202     
+ Misses        638      637       -1     
  Partials      262      262              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaszig vaszig force-pushed the feature/3725-add-problems-to-email-digest branch from 3077185 to 183f152 Compare April 4, 2024 07:28
@vaszig vaszig marked this pull request as ready for review April 4, 2024 07:46
@vaszig vaszig marked this pull request as draft April 4, 2024 09:41
@vaszig vaszig force-pushed the feature/3725-add-problems-to-email-digest branch from 183f152 to 6470ff8 Compare April 4, 2024 09:49
@vaszig vaszig marked this pull request as ready for review April 4, 2024 09:49
@vaszig vaszig marked this pull request as draft April 4, 2024 10:06
@vaszig vaszig force-pushed the feature/3725-add-problems-to-email-digest branch from 6470ff8 to 8114604 Compare April 4, 2024 10:14
@vaszig vaszig marked this pull request as ready for review April 4, 2024 10:32
@vaszig vaszig force-pushed the feature/3725-add-problems-to-email-digest branch from 3d70ffe to 8410e69 Compare April 5, 2024 07:13
src/openforms/emails/utils.py Outdated Show resolved Hide resolved
src/openforms/emails/utils.py Outdated Show resolved Hide resolved
src/openforms/logging/logevent.py Outdated Show resolved Hide resolved
src/openforms/registrations/utils.py Outdated Show resolved Hide resolved
src/openforms/registrations/utils.py Outdated Show resolved Hide resolved
src/openforms/registrations/utils.py Outdated Show resolved Hide resolved
src/openforms/emails/utils.py Outdated Show resolved Hide resolved
src/openforms/emails/tasks.py Outdated Show resolved Hide resolved
src/openforms/emails/templates/emails/admin_digest.html Outdated Show resolved Hide resolved
src/openforms/registrations/utils.py Outdated Show resolved Hide resolved
src/openforms/emails/tasks.py Outdated Show resolved Hide resolved
src/openforms/emails/tasks.py Outdated Show resolved Hide resolved
src/openforms/emails/tasks.py Outdated Show resolved Hide resolved
src/openforms/emails/tasks.py Outdated Show resolved Hide resolved
src/openforms/logging/logevent.py Outdated Show resolved Hide resolved
src/openforms/registrations/utils.py Outdated Show resolved Hide resolved
src/openforms/registrations/utils.py Outdated Show resolved Hide resolved
src/openforms/registrations/utils.py Outdated Show resolved Hide resolved
src/openforms/submissions/admin.py Show resolved Hide resolved
Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more details :)

src/openforms/emails/templates/emails/admin_digest.html Outdated Show resolved Hide resolved
src/openforms/emails/templates/emails/admin_digest.html Outdated Show resolved Hide resolved
src/openforms/emails/templates/emails/admin_digest.html Outdated Show resolved Hide resolved
src/openforms/emails/tests/test_tasks.py Outdated Show resolved Hide resolved
src/openforms/emails/views.py Outdated Show resolved Hide resolved
src/openforms/submissions/admin.py Outdated Show resolved Hide resolved
src/openforms/logging/service.py Outdated Show resolved Hide resolved
src/openforms/logging/service.py Outdated Show resolved Hide resolved
src/openforms/submissions/utils.py Outdated Show resolved Hide resolved
src/openforms/logging/service.py Outdated Show resolved Hide resolved
@sergei-maertens sergei-maertens merged commit 2ee5b30 into master Apr 10, 2024
27 checks passed
@sergei-maertens sergei-maertens deleted the feature/3725-add-problems-to-email-digest branch April 10, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect more problems and add them to the email digest
3 participants