Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't validate step that is not applicable #4075

Merged

Conversation

sergei-maertens
Copy link
Member

Closes #4068

Another case that was missed

@sergei-maertens sergei-maertens added the needs-backport Fix must be backported to stable release branch label Mar 28, 2024
@sergei-maertens sergei-maertens force-pushed the issue/4068-dont-validate-step-that-is-not-applicable branch from ec1f545 to 784774b Compare March 28, 2024 10:13
@sergei-maertens sergei-maertens marked this pull request as ready for review March 28, 2024 10:13
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.08%. Comparing base (5feee6c) to head (784774b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4075      +/-   ##
==========================================
+ Coverage   96.06%   96.08%   +0.01%     
==========================================
  Files         728      728              
  Lines       22930    22931       +1     
  Branches     2666     2667       +1     
==========================================
+ Hits        22028    22033       +5     
+ Misses        639      636       -3     
+ Partials      263      262       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens merged commit 8430ac2 into master Mar 28, 2024
27 checks passed
@sergei-maertens sergei-maertens deleted the issue/4068-dont-validate-step-that-is-not-applicable branch March 28, 2024 10:31
@sergei-maertens
Copy link
Member Author

Backported to stable/2.6.x via 3fbbca2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport Fix must be backported to stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot submit form due to new backend validation
2 participants