[#4031] Add a confirm popup when switching to v2 options #4054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viicos
commented
Mar 25, 2024
Comment on lines
+44
to
+47
| if (realVersion === 1) { | ||
| const confirmV1Switch = window.confirm(v1SwitchMessage); | ||
| if (!confirmV1Switch) return; | ||
| } |
There was a problem hiding this comment.
I could also not show the popup if variablesMapping is empty, but probably not necessary
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4054 +/- ##
=======================================
Coverage 96.07% 96.07%
=======================================
Files 728 728
Lines 22892 22892
Branches 2659 2659
=======================================
Hits 21994 21994
Misses 636 636
Partials 262 262 ☔ View full report in Codecov by Sentry. |
8 tasks
sergei-maertens
approved these changes
Mar 25, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4031.
This was discussed at some point but forgot about it