Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3969] Remove ability to override LoA for eHekrenning/eIDAS #4045

Merged
merged 8 commits into from
Apr 2, 2024

Conversation

SilviaAmAm
Copy link
Contributor

Fixes #3969 (partially, needs also the changes here: maykinmedia/django-digid-eherkenning#65)

@SilviaAmAm SilviaAmAm marked this pull request as draft March 22, 2024 14:44
@SilviaAmAm SilviaAmAm force-pushed the fix/3969-remove-eherkenning-loa-overwrite branch from 5e30120 to ed614ea Compare March 22, 2024 14:45
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.08%. Comparing base (bdf53af) to head (ff05b99).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4045      +/-   ##
==========================================
- Coverage   96.08%   96.08%   -0.01%     
==========================================
  Files         729      729              
  Lines       22980    22974       -6     
  Branches     2674     2674              
==========================================
- Hits        22080    22074       -6     
  Misses        638      638              
  Partials      262      262              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SilviaAmAm SilviaAmAm force-pushed the fix/3969-remove-eherkenning-loa-overwrite branch from ed614ea to 979dc54 Compare March 22, 2024 15:43
@SilviaAmAm SilviaAmAm force-pushed the fix/3969-remove-eherkenning-loa-overwrite branch from 979dc54 to fddc19e Compare March 29, 2024 16:08
@SilviaAmAm SilviaAmAm force-pushed the fix/3969-remove-eherkenning-loa-overwrite branch from fddc19e to ff05b99 Compare April 2, 2024 07:43
@SilviaAmAm SilviaAmAm marked this pull request as ready for review April 2, 2024 07:53
@sergei-maertens sergei-maertens merged commit dba0ffe into master Apr 2, 2024
28 checks passed
@sergei-maertens sergei-maertens deleted the fix/3969-remove-eherkenning-loa-overwrite branch April 2, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the current implementation of eHerkenning/eIDAS level selection per form
2 participants