[#72] Add backend validation of form rules #4029

vaszig · 2024-03-20T15:45:46Z

Partly closes #72

This PR handles the following components, the rest of them will be handled in an another PR:

textarea
time
postcode
bsn (11-check)
select
checkbox
currency
signature
map

codecov · 2024-03-21T13:07:49Z

Codecov Report

Attention: Patch coverage is 98.55072% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 96.10%. Comparing base (2b7b6b6) to head (2db8fd0).
Report is 4 commits behind head on master.

Files	Patch %	Lines
src/openforms/formio/components/custom.py	92.59%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4029      +/-   ##
==========================================
+ Coverage   96.07%   96.10%   +0.02%     
==========================================
  Files         729      730       +1     
  Lines       22980    23094     +114     
  Branches     2674     2698      +24     
==========================================
+ Hits        22078    22194     +116     
+ Misses        639      638       -1     
+ Partials      263      262       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/openforms/formio/components/vanilla.py

src/openforms/formio/tests/validation/test_currency.py

src/openforms/formio/typing/vanilla.py

sergei-maertens

I'm not seeing the matching e2e tests yet? These are important to ensure that the frontend and backend behaviour are aligned:

https://github.com/open-formulieren/open-forms/blob/master/src/openforms/tests/e2e/test_input_validation.py

src/openforms/formio/components/vanilla.py

src/openforms/formio/tests/validation/test_map.py

src/openforms/formio/tests/validation/test_time.py

src/openforms/formio/components/vanilla.py

src/openforms/tests/e2e/input_validation_base.py

src/openforms/tests/e2e/test_input_validation.py

src/openforms/formio/api/validators.py

src/openforms/tests/e2e/test_input_validation.py

src/openforms/formio/components/vanilla.py

This commit handles the backend validation for the following components: - textarea - time - postcode - bsn (11-check) - select - checkbox - currency - signature - map

* Refactored and moved validator * Added more tests * Fixed warning in playwright test

sergei-maertens · 2024-03-29T16:06:39Z

I tested some more complex forms that revealed some validation issues before, and as far as I can tell this doesn't introduce new problems yet, but not all component types were used in there 😬

Use accurate keys/labels for the components being tested.

* Especially text-based fields with multiple: true are problematic * Fixed textarea

* Ensure multiple false|true is handled appropriately * Model current behaviour of frontend data in tests * Ensure that empty options are treated correctly depending on required/optional config

sergei-maertens

@vaszig do you mind sanity checking my changes?

vaszig

I would approve this but github doesn't let me to do so..

The only thing, as mentioned in slack as well, is something like splitting some things like the TimeBetweenValidator and the custom field, but I guess this can be done in the next-relative PR which is open.

vaszig · 2024-04-02T09:36:20Z

src/openforms/formio/tests/validation/test_time.py

+
+        is_valid, _ = validate_formio_data(component, {"time": "15:36"})
+
+        self.assertTrue(is_valid)


I am missing something here. Could you please explain why we have this behaviour here?

coverage reporting complained about missing branch coverage on the match statement, so this is what it addresses - it happens that invalid configuration ends up in the JSON and this ensures it is logged/covered by tests :)

vaszig marked this pull request as draft March 20, 2024 15:45

vaszig force-pushed the task/72-backend-validation-of-form-rules branch from 52ee39e to 69cdcc9 Compare March 21, 2024 12:59

vaszig marked this pull request as ready for review March 21, 2024 13:53

SilviaAmAm self-requested a review March 21, 2024 14:55

SilviaAmAm reviewed Mar 21, 2024

View reviewed changes

sergei-maertens requested changes Mar 21, 2024

View reviewed changes

src/openforms/formio/components/vanilla.py Outdated Show resolved Hide resolved

src/openforms/formio/tests/validation/test_map.py Show resolved Hide resolved

src/openforms/formio/tests/validation/test_time.py Outdated Show resolved Hide resolved

sergei-maertens requested changes Mar 25, 2024

View reviewed changes

This was referenced Mar 26, 2024

[#72] Remaining backend validation of form rules #4062

Closed

[#72] Backend validation of remaining components #4063

Closed

sergei-maertens reviewed Mar 26, 2024

View reviewed changes

sergei-maertens reviewed Mar 27, 2024

View reviewed changes

src/openforms/tests/e2e/test_input_validation.py Outdated Show resolved Hide resolved

src/openforms/tests/e2e/test_input_validation.py Outdated Show resolved Hide resolved

sergei-maertens reviewed Mar 27, 2024

View reviewed changes

src/openforms/formio/components/vanilla.py Outdated Show resolved Hide resolved

vaszig added 5 commits March 29, 2024 16:26

[#72] Added backend validation for specific components

2c28bae

This commit handles the backend validation for the following components: - textarea - time - postcode - bsn (11-check) - select - checkbox - currency - signature - map

[#72] PR feedback

6090c8a

[#72] Added e2e tests, processed PR feedback

f5b4634

[#72] PR feedback

44e563b

[72] PR feedback

a68c8fd

sergei-maertens force-pushed the task/72-backend-validation-of-form-rules branch from 842d756 to a68c8fd Compare March 29, 2024 15:27

🎨 [#72] Clean up checkbox validation

17e0fbf

* Refactored and moved validator * Added more tests * Fixed warning in playwright test

sergei-maertens added 3 commits March 29, 2024 17:13

🎨 [#72] Clean up test data/fixtures

87bcbd4

Use accurate keys/labels for the components being tested.

🦺 [#72] Implement time component validations

f572791

✅ [#72] Add tests for known edge/bug cases

bc7fcfe

* Especially text-based fields with multiple: true are problematic * Fixed textarea

sergei-maertens force-pushed the task/72-backend-validation-of-form-rules branch from 4f27452 to bc7fcfe Compare April 2, 2024 07:23

🦺 [#72] Fine tune validations of selects fields

2db8fd0

* Ensure multiple false|true is handled appropriately * Model current behaviour of frontend data in tests * Ensure that empty options are treated correctly depending on required/optional config

sergei-maertens approved these changes Apr 2, 2024

View reviewed changes

vaszig commented Apr 2, 2024

View reviewed changes

sergei-maertens merged commit 31380fa into master Apr 2, 2024
27 checks passed

sergei-maertens deleted the task/72-backend-validation-of-form-rules branch April 2, 2024 10:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#72] Add backend validation of form rules #4029

[#72] Add backend validation of form rules #4029

vaszig commented Mar 20, 2024 •

edited

Loading

codecov bot commented Mar 21, 2024 •

edited

Loading

sergei-maertens left a comment

sergei-maertens commented Mar 29, 2024

sergei-maertens left a comment

vaszig left a comment

vaszig Apr 2, 2024

sergei-maertens Apr 2, 2024


		is_valid, _ = validate_formio_data(component, {"time": "15:36"})

		self.assertTrue(is_valid)

[#72] Add backend validation of form rules #4029

[#72] Add backend validation of form rules #4029

Conversation

vaszig commented Mar 20, 2024 • edited Loading

codecov bot commented Mar 21, 2024 • edited Loading

Codecov Report

sergei-maertens left a comment

Choose a reason for hiding this comment

sergei-maertens commented Mar 29, 2024

sergei-maertens left a comment

Choose a reason for hiding this comment

vaszig left a comment

Choose a reason for hiding this comment

vaszig Apr 2, 2024

Choose a reason for hiding this comment

sergei-maertens Apr 2, 2024

Choose a reason for hiding this comment

vaszig commented Mar 20, 2024 •

edited

Loading

codecov bot commented Mar 21, 2024 •

edited

Loading