-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#3688] Add documentation #4028
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4028 +/- ##
=======================================
Coverage 96.07% 96.07%
=======================================
Files 728 728
Lines 22867 22867
Branches 2654 2654
=======================================
Hits 21970 21970
Misses 636 636
Partials 261 261 ☔ View full report in Codecov by Sentry. |
Wow, that's a lot of typos, thanks for reviewing |
df1ed7a
to
096a311
Compare
|
||
Below is an example of the contents in the ``record.data`` attribute in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decided to remove this, there is no added benefit for functional admins since they're not typically involved with form-configuration, and it's way too technical for form designers.
The Productaanvraag objecttype is linked above, that should be sufficient :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes wasn't sure what to do with this
These fields are obsolete and scheduled for removal. Their values have been copied into the respective forms where they were not set explicitly yet.
* Updated technical (functional admin) documentation * Documented minimum required version of Objects API 2.2 * Removed distinction between new/legacy - the form fields are marked as required anyway and the nuance is not interesting. * Translated the manual documentation to Dutch * Moved form-level manual documentation into registrations section * Added extra pointers on how to configure this thing, with a bit more logical progression.
096a311
to
9841216
Compare
Part of #3688, #4019
probably still WIP and missing things