Fix wrong type for validation properties #4018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Formio uses empty strings for length-indication defaults in the validation configuration (minLength, maxLength, min, max, minWords, maxWords) which leaks into textfield, number and derived components like email, phone number... This is wrong for a number of reasons: 1. Semantically you'd expect undefined or null, not an empty string 2. Comparing string with a number to perform validation crashes the backend 3. Their own typescript types are defined as 'maxLength?: number', stating that it's either undefined or a number. Using 'null' will cause us typescript issues, so the patch targets these invalid defaults and deletes the keys alltogether, which results in: 1. it being 'undefined' in the frontend code, which should pass the falsy checks 2. the missing key in the backend will default to 'None', which is explicitly checked. This only applies to new components, existing data needs a data migration to correct this.
The invalid validate keys are dropped from the existing configuration. This patch also ensures that old form imports are automatically patched up during import.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4018 +/- ##
=======================================
Coverage 96.02% 96.03%
=======================================
Files 728 728
Lines 22792 22801 +9
Branches 2636 2639 +3
=======================================
+ Hits 21887 21896 +9
Misses 649 649
Partials 256 256 ☔ View full report in Codecov by Sentry. |
vaszig
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4016
The fix is two-fold: